New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cadvisor and other repos for klog #70889

Merged
merged 5 commits into from Nov 10, 2018

Conversation

@dims
Copy link
Member

dims commented Nov 9, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Move from the old github.com/golang/glog to k8s.io/klog
  • klog as explicit InitFlags() so we add them as necessary
  • we update the other repositories that we vendor that made a similar
    change from glog to klog
    • github.com/kubernetes/repo-infra
    • k8s.io/gengo/
    • k8s.io/kube-openapi/
    • github.com/google/cadvisor
  • Entirely remove all references to glog
  • Fix some tests by explicit InitFlags in their init() methods

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70264

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 9, 2018

/priority important-soon

@dims dims changed the title Update cadvisor and other repos for klog take 2 Update cadvisor and other repos for klog Nov 9, 2018

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 9, 2018

/test pull-kubernetes-e2e-gke

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 9, 2018

@dims dims force-pushed the dims:update-cadvisor-and-other-repos-for-klog-take-2 branch from 77df3a7 to 513f595 Nov 9, 2018

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 9, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 9, 2018

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Nov 10, 2018

Racking up the big numbers!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 10, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

dims added some commits Nov 9, 2018

Move from glog to klog
- Move from the old github.com/golang/glog to k8s.io/klog
- klog as explicit InitFlags() so we add them as necessary
- we update the other repositories that we vendor that made a similar
change from glog to klog
  * github.com/kubernetes/repo-infra
  * k8s.io/gengo/
  * k8s.io/kube-openapi/
  * github.com/google/cadvisor
- Entirely remove all references to glog
- Fix some tests by explicit InitFlags in their init() methods

Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
Update vendor dependencies
Change-Id: I3b1ca9f2687388c831d9d46a4e1de413ffae06ac
Fix issues with verify-imports.sh
Change-Id: I31aa2483065a4ef6acb65c18cda73c325c432df3
Update all the staging Godeps.json
Change-Id: I64b30c68a606b4f5c095a66496a1e48c4d62ea88
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

s/glog/klog/ - keep up with master
Change-Id: I27ff0545bc456ed8c0900cfeb90555f9ab7ae235

@dims dims force-pushed the dims:update-cadvisor-and-other-repos-for-klog-take-2 branch from 513f595 to e558e29 Nov 10, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 10, 2018

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 10, 2018

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 10, 2018

reapply /lgtm from @thockin as this was a simple rebase.

@dims dims added the lgtm label Nov 10, 2018

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 10, 2018

/test pull-kubernetes-e2e-gke

@k8s-ci-robot k8s-ci-robot merged commit a3ccea9 into kubernetes:master Nov 10, 2018

18 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@gyuho gyuho referenced this pull request Nov 15, 2018

Merged

Update cloud provider #19

@mcrute mcrute referenced this pull request Nov 15, 2018

Open

Migrate from glog to klog #20

k8s-ci-robot pushed a commit that referenced this pull request Nov 23, 2018

replace golang.org/x/exp/inotify with standalone library
The inotify code was removed from golang.org/x/exp several years ago. Therefore
importing it from that path prevents downstream consumers from using any module
that makes use of more recent features of golang.org/x/exp.

This change is a followup to google/cadvisor#2060 which was merged with #70889

This fixes #68478

@ash2k ash2k referenced this pull request Dec 12, 2018

Merged

Migrate from glog to klog #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment