New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log_file option to kubelet flags #70917

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@dims
Copy link
Member

dims commented Nov 11, 2018

Change-Id: I5e75902739e2f869244d1b8b229be2580aca8149

What type of PR is this?
/kind bug

What this PR does / why we need it:
klog supports a log-file option, make sure kubelet command line help options show this new option

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubelet now supports `log-file` option to write logs directly to a specific file
add log_file option to kubelet flags
Change-Id: I5e75902739e2f869244d1b8b229be2580aca8149
@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 11, 2018

/priority important-soon

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 12, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 12, 2018

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 16, 2018

/assign @yujuhong
/assign @Random-Liu

@yujuhong

This comment has been minimized.

Copy link
Contributor

yujuhong commented Nov 16, 2018

@dims I think I missed the announcement on klog. Could you point me to docs explaining why we're doing this? Thank you.

Why is this needed for 1.13? :-)

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 16, 2018

@yujuhong you missed a whole bunch :)

https://groups.google.com/d/msg/kubernetes-dev/7vnijOMhLS0/1oRiNtigBgAJ

TL;DR klog now supports this option and we should expose it. ( cc @tallclair )

@yujuhong

This comment has been minimized.

Copy link
Contributor

yujuhong commented Nov 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 16, 2018

@yujuhong

This comment has been minimized.

Copy link
Contributor

yujuhong commented Nov 16, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5ec9349 into kubernetes:master Nov 16, 2018

18 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment