Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1 to use Fluentd v1.2. #70954

Merged
merged 1 commit into from Nov 26, 2018

Conversation

@qingling128
Copy link
Contributor

commented Nov 12, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1 to use Fluentd v1.2.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1 to use Fluentd v1.2. This provides nanoseconds timestamp granularity for logs.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2018

Hi @qingling128. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qingling128

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

/assign @vishh @x13n

@x13n

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

/ok-to-test
/lgtm

@x13n

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

/approve

@qingling128

This comment has been minimized.

Copy link
Contributor Author

commented Nov 13, 2018

/test pull-kubernetes-e2e-gce-100-performance

@qingling128

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

@x13n - Any chance you could help with the Must be in milestone v1.13. blocker?

@x13n

This comment has been minimized.

Copy link
Member

commented Nov 15, 2018

I cannot add this to the milestone myself. Also, note that you still need cluster/gce/OWNERS approval.

@AishSundar Is it possible to add this PR to 1.13 milestone, given that change is GCP-specific and doesn't affect non-GCP code?

@qingling128

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

Could someone (from cluster/gce/OWNERS) help take a look at this PR? @vishh @MaciekPytel

@qingling128

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

@vishh

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qingling128, vishh, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vishh vishh added this to the v1.13 milestone Nov 26, 2018

@AishSundar

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot merged commit 396271c into kubernetes:master Nov 26, 2018

18 checks passed

cla/linuxfoundation qingling128 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2018
Merge pull request #71442 from qingling128/automated-cherry-pick-of-#…
…70954-upstream-release-1.12

Automated cherry pick of #70954: Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1
k8s-ci-robot added a commit that referenced this pull request Nov 30, 2018
Merge pull request #71444 from qingling128/automated-cherry-pick-of-#…
…70954-upstream-release-1.10

Automated cherry pick of #70954: Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1
k8s-ci-robot added a commit that referenced this pull request Dec 3, 2018
Merge pull request #71443 from qingling128/automated-cherry-pick-of-#…
…70954-upstream-release-1.11

Automated cherry pick of #70954: Upgrade Stackdriver Logging Agent addon image to 0.6-1.6.0-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.