Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Recognize newer docker versions without -ce/-ee suffix: 18.09.0 #71001
What type of PR is this?
What this PR does / why we need it:
This was not expected by the docker_validator version regexp, which
This commit relax the version regexp to also recognize
Which issue(s) this PR fixes (optional, in
Initially encountered in minikube: kubernetes/minikube#3323
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Not sure about the need for a release note or its phrasing.
Hi @thomas-riccardi. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Nov 13, 2018
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Nov 13, 2018
17 checks passed
Thanks all for the quick responses!
Should this PR be cherry-picked on release branches? Which ones? Who should do that?
I only found https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md which only explains how to do it. Is there more documentation about backports somewhere?
if you have a strong opinion about a cherry pick for 1.12 you can create a proposal in a kubernetes/kubeadm issue.