New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump metadata-proxy to v0.1.11, update tests & test image #71094

Merged
merged 1 commit into from Dec 18, 2018

Conversation

@dekkagaijin
Copy link
Contributor

dekkagaijin commented Nov 15, 2018

Picks up GoogleCloudPlatform/k8s-metadata-proxy#26

@mikedanese PTAL

/kind bug

In addition to restricting GCE metadata requests to known APIs, the metadata-proxy now restricts query strings to known parameters.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 15, 2018

Hi @dekkagaijin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from ixdy Nov 15, 2018

@dekkagaijin dekkagaijin force-pushed the dekkagaijin:update-concealment branch from 6f992ca to d6eac16 Nov 15, 2018

@mikedanese

This comment has been minimized.

Copy link
Member

mikedanese commented Nov 15, 2018

/ok-to-test
/sig gcp
/priority important-soon

@mikedanese

This comment has been minimized.

Copy link
Member

mikedanese commented Nov 16, 2018

@dekkagaijin tests are broke.

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Nov 16, 2018

The tests should get a job and stop making us working folk deal with their failures.

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Nov 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 16, 2018

@cjcullen cjcullen added this to the v1.13 milestone Nov 16, 2018

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Nov 16, 2018

/approve

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Nov 16, 2018

/retest

@nikopen

This comment has been minimized.

Copy link
Member

nikopen commented Nov 16, 2018

tests seem to be failing for this, if it's not critical for v1.13.0 then it has to be moved out as code freeze is today at 5pm PST

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 16, 2018

/approve
/retest

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 16, 2018

/approve
/retest

webhook dropped?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjcullen, dekkagaijin, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 16, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@mikedanese mikedanese removed the lgtm label Nov 16, 2018

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Nov 16, 2018

[sig-auth] Metadata Concealment should run a check-metadata-concealment job to completion failed, which seems problematic?

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Nov 17, 2018

@ixdy yeah, looks like there's no insight into the failure in the logs, so I'll have to get a test cluster setup myself

@nikopen

This comment has been minimized.

Copy link
Member

nikopen commented Nov 19, 2018

@dekkagaijin @ixdy Is this critical for 1.13 GCE? If not, it should be moved out to a patch release

/priority critical-urgent

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 19, 2018

@ixdy @dekkagaijin is this needed for 1.13? We are code freeze and I rather wait to take this in for 1.14 if its not critical

/remove-priority critical-urgent

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Nov 19, 2018

Is master a sensitive branch?

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Nov 19, 2018

Not critical

@nikopen

This comment has been minimized.

Copy link
Member

nikopen commented Nov 19, 2018

master will become 1.13.0 in a few weeks, and PRs to master are gatekeeped just before the release. Let's move this to post release so it merges for 1.13.1 or others

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.13 milestone Nov 19, 2018

@dekkagaijin dekkagaijin force-pushed the dekkagaijin:update-concealment branch from d6eac16 to 2a6dd3b Nov 19, 2018

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Nov 20, 2018

Anything works, I'll keep an eye on this PR

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Dec 13, 2018

Pinging this again now that 1.13 is out

@cjcullen

This comment has been minimized.

Copy link
Member

cjcullen commented Dec 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 17, 2018

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Dec 17, 2018

/retest pull-kubernetes-godeps

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Dec 17, 2018

/retest

@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Dec 17, 2018

/test pull-kubernetes-e2e-kops-aws

1 similar comment
@dekkagaijin

This comment has been minimized.

Copy link
Contributor

dekkagaijin commented Dec 18, 2018

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot merged commit 12be140 into kubernetes:master Dec 18, 2018

19 checks passed

cla/linuxfoundation dekkagaijin authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment