New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: Allow customizing the image repository via flags #71135

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@luxas
Copy link
Member

luxas commented Nov 16, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Based on feedback from KubeCon China.
Honestly, I thought we had this feature long time ago already.
This is a great UX improvement for those behind the GFW
(which I've now been myself the latest week).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
This targets GA / v1.13

Does this PR introduce a user-facing change?:

kubeadm now supports the `--image-repository` flag for customizing what registry to pull images from

@kubernetes/sig-cluster-lifecycle-pr-reviews

@timothysc
Copy link
Member

timothysc left a comment

/approve

looks clean to me, but defer to @fabriziopandini if it will affect the all change in any way.

@fabriziopandini
Copy link
Contributor

fabriziopandini left a comment

@luxas thanks!
/approve
/lgtm

@timothysc at first sight no interference with the other PR in flights, but I will keep an eye on merge

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 16, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, luxas, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rdodev

This comment has been minimized.

Copy link
Contributor

rdodev commented Nov 16, 2018

/LGTM

Thanks for quick turnaround to meet user feedback!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 16, 2018

@rdodev: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

/LGTM

Thanks for quick turnaround to meet user feedback!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timothysc

This comment has been minimized.

Copy link
Member

timothysc commented Nov 16, 2018

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-100-performance

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 16, 2018

/priority critical-urgent
/remove-priority important-soon

Setting priority to critical-urgent to prevent it from getting kicked out of merge queue in case Tide doesnt get to it by Code freeze time.

@k8s-ci-robot k8s-ci-robot merged commit fab7009 into kubernetes:master Nov 16, 2018

18 checks passed

cla/linuxfoundation luxas authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@luxas

This comment has been minimized.

Copy link
Member

luxas commented Nov 16, 2018

Thanks @AishSundar!

@RainingNight

This comment has been minimized.

Copy link

RainingNight commented Nov 19, 2018

Support pod-infra-container-image?

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 19, 2018

1.13 uses imageRepository for pod-infra-container-image.

@RainingNight

This comment has been minimized.

Copy link

RainingNight commented Nov 20, 2018

Very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment