Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename '--experimental-encryption-provider-config' to '--encryption-provider-config' #71206
This change renames the '--experimental-encryption-provider-config' flag to '--encryption-provider-config'. The old flag is accepted but generates a warning.
In 1.14, we will drop support for '--experimental-encryption-provider-config' entirely.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Hi @stlaz. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
referenced this pull request
Nov 19, 2018
Nov 19, 2018
This is the alternative to #61592, 61592 was stuck behind other PRs and in rebase-hell. This does not alter the logic in any way or drop support for the older option. This just marks the older one as deprecated and adds a new option that exercises the same code as the old option
cc @smarterclayton @immutableT for evaluation (https://github.com/kubernetes/kubernetes/blob/master/OWNERS_ALIASES#L76-L78), since this is effectively graduating the encryption feature from experimental
Weird, my IDE started doing that. Fixed with vim...
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
2 similar comments
both the old and new flag are still accepted. the same gke error appears in other PR jobs: https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71124/pull-kubernetes-e2e-gke/3445/