Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: improve hostport parsing error messages #71258

Conversation

@bart0sh
Copy link
Contributor

commented Nov 20, 2018

What this PR does / why we need it:

Added hostport and host/port parts to the error messages
produced by ParseHostPort API.

This should help users to better identify parsing issues.

Which issue(s) this PR fixes:

Fixes: kubernetes/kubeadm#1159

Does this PR introduce a user-facing change?:

kubeadm: improve hostport parsing error messages
@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2018

Added hostport and host/port parts to the error messages
produced by ParseHostPort API.

This should help users to better identify parsing issues.

Fixes: kubernetes/kubeadm#1159
@bart0sh bart0sh force-pushed the bart0sh:PR0042-kubeadm-1159-improve-hostport-error-messages branch from 37d99a2 to bab556f Nov 20, 2018
@k8s-ci-robot k8s-ci-robot requested a review from detiber Nov 20, 2018
Copy link
Member

left a comment

@bart0sh
thanks a lot. LGTM.

due to code freeze it has to wait after 1.13 is released.
only kind/bug, priority/critical-urgent makes it in.

/kind cleanup
/priority important-longterm

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2018

/test pull-kubernetes-e2e-gce-100-performance

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Dec 4, 2018

/retest

@bart0sh

This comment has been minimized.

Copy link
Contributor Author

commented Dec 4, 2018

@neolit123 Kindly ping for lgtm&approve.

Copy link
Member

left a comment

@bart0sh
Thanks and sorry for the delay in reviewing this PR.
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 10, 2018
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21a8d08 into kubernetes:master Dec 10, 2018
18 checks passed
18 checks passed
cla/linuxfoundation bart0sh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.