New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce NodeKiller -- a utility to simulate node failures in e2e tests #71320

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@mborsz
Copy link
Member

mborsz commented Nov 21, 2018

What type of PR is this?
/kind flake

What this PR does / why we need it:
For purposes of scalability tests, we need to simulate node failures.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/cc @wojtek-t

@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented Nov 21, 2018

This PR contains draft of the change. Will update when it's ready for review.

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Nov 22, 2018

@mborsz - given that we would like to migrate to ClusterLoader hopefully really soon, we should consider integrating it with ClusterLoader instead, maybe?

@mborsz mborsz force-pushed the mborsz:nodekiller branch from 3463bcd to bc6d0b6 Nov 23, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Nov 23, 2018

@mborsz mborsz force-pushed the mborsz:nodekiller branch 4 times, most recently from 15aa6f5 to 33b309c Nov 23, 2018

@mborsz mborsz changed the title [WIP] Introduce NodeKiller -- an utility to simulate node failures in e2e tests Introduce NodeKiller -- an utility to simulate node failures in e2e tests Nov 23, 2018

@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented Nov 23, 2018

I think it's ready for review.

@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented Nov 23, 2018

@mborsz mborsz force-pushed the mborsz:nodekiller branch 2 times, most recently from f791f11 to 4d09199 Nov 23, 2018

@mborsz mborsz changed the title Introduce NodeKiller -- an utility to simulate node failures in e2e tests Introduce NodeKiller -- a utility to simulate node failures in e2e tests Nov 23, 2018

@mborsz mborsz force-pushed the mborsz:nodekiller branch 2 times, most recently from 59b9962 to 8f0a845 Nov 23, 2018

@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented Nov 29, 2018

/assign @wojtek-t

Show resolved Hide resolved test/e2e/e2e.go Outdated
Show resolved Hide resolved test/e2e/framework/nodes_util.go Outdated
Show resolved Hide resolved test/e2e/framework/nodes_util.go Outdated

@mborsz mborsz force-pushed the mborsz:nodekiller branch 2 times, most recently from 3a4830b to 643e54c Nov 29, 2018

@wojtek-t
Copy link
Member

wojtek-t left a comment

One minor comment - other than that lgtm.

Show resolved Hide resolved test/e2e/framework/nodes_util.go Outdated

@mborsz mborsz force-pushed the mborsz:nodekiller branch from 643e54c to 9e0493c Nov 29, 2018

@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Nov 29, 2018

@mborsz

This comment has been minimized.

Copy link
Member Author

mborsz commented Nov 29, 2018

PTAL

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Nov 29, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 29, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mborsz mborsz force-pushed the mborsz:nodekiller branch from 9e0493c to 9e493e1 Nov 29, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 29, 2018

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Nov 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 29, 2018

@k8s-ci-robot k8s-ci-robot merged commit ba5f1cb into kubernetes:master Nov 29, 2018

18 checks passed

cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

mborsz added a commit to mborsz/perf-tests that referenced this pull request Dec 19, 2018

Migrate NodeKiller to clusterloader2.
This is basically copy-paste of
kubernetes/kubernetes#71320.

In the next step, once we migrate -killer job to clusterloader2, I will
remove NodeKiller from kubernetes/kubernetes repo to remove duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment