Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use named custom func #71447
What type of PR is this?
What this PR does / why we need it:
cobra can handle a custom function name for
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
I did the following steps to update the cobra revision.
$ hack/run-in-gopath.sh bash -c 'rm -rf $GOPATH/src/github.com/spf13/cobra' $ hack/run-in-gopath.sh go get github.com/mitchellh/go-homedir $ hack/run-in-gopath.sh go get -d github.com/spf13/cobra $ hack/run-in-gopath.sh bash -c 'git -C $GOPATH/src/github.com/spf13/cobra checkout 6fd8e29' $ hack/run-in-gopath.sh hack/godep-save.sh
Does this PR introduce a user-facing change?:
Hi @dtaniwaki. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Dec 7, 2018
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dtaniwaki
If they are not already assigned, you can assign the PR to them by writing
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing