New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node-Problem-Detector v0.6.0 on GCI #71522

Merged
merged 1 commit into from Dec 3, 2018

Conversation

@wangzhen127
Copy link
Member

wangzhen127 commented Nov 28, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
Use Node-Problem-Detector v0.6.0 on GCI. NPD v0.6.0 added a few more plugins to detect more node problems. It also fixed a custom plugin bug. This is part of #71526.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
This PR also updates the kubeconfig needed by NPD and fixes kubernetes/node-problem-detector#227

Special notes for your reviewer:
Currently v0.5.0 is being used.

Does this PR introduce a user-facing change?:

On GCI, NPD starts to monitor kubelet, docker, containerd crashlooping, read-only filesystem and corrupt docker overlay2 issues.
@wangzhen127

This comment has been minimized.

Copy link
Member

wangzhen127 commented Nov 28, 2018

/sig node
/assign @Random-Liu

@wangzhen127

This comment has been minimized.

Copy link
Member

wangzhen127 commented Nov 28, 2018

/sig gcp

@wangzhen127 wangzhen127 changed the title Use Node-Problem-Detector v0.6.0 Use Node-Problem-Detector v0.6.0 on GCI Nov 28, 2018

@wangzhen127

This comment has been minimized.

Copy link
Member

wangzhen127 commented Nov 30, 2018

Just verified node-problem-detector.log in pull-kubernetes-e2e-gke and pull-kubernetes-e2e-gce and NPD is working correctly.

/assign @yguo0905

@yguo0905

This comment has been minimized.

Copy link
Contributor

yguo0905 commented Dec 3, 2018

/lgtm
/hold
hold if you also want others to lgtm.

@yguo0905

This comment has been minimized.

Copy link
Contributor

yguo0905 commented Dec 3, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Random-Liu

This comment has been minimized.

Copy link
Member

Random-Liu commented Dec 3, 2018

/lgtm

@wangzhen127

This comment has been minimized.

Copy link
Member

wangzhen127 commented Dec 3, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 4206790 into kubernetes:master Dec 3, 2018

18 checks passed

cla/linuxfoundation wangzhen127 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@wangzhen127 wangzhen127 deleted the wangzhen127:npd branch Dec 3, 2018

k8s-ci-robot added a commit that referenced this pull request Dec 8, 2018

Merge pull request #71718 from wangzhen127/automated-cherry-pick-of-#…
…71522-upstream-release-1.12

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0

k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018

Merge pull request #71721 from wangzhen127/automated-cherry-pick-of-#…
…71522-upstream-release-1.10

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0

k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018

Merge pull request #71717 from wangzhen127/automated-cherry-pick-of-#…
…71522-upstream-release-1.13

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0

k8s-ci-robot added a commit that referenced this pull request Dec 11, 2018

Merge pull request #71720 from wangzhen127/automated-cherry-pick-of-#…
…71522-upstream-release-1.11

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0
@wangzhen127

This comment has been minimized.

Copy link
Member

wangzhen127 commented Dec 11, 2018

Cherry picks are all merged. NPD v0.6.0 will be available in the following releases:
v1.10.12, v1.11.6, v1.12.4, v1.13.1, v1.14+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment