Support Table and PartialObjectMetadata on watch #71548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
needs-sig
smarterclayton
force-pushed
the
watch_converted
branch
from
1ec127a to
c4b3391
Compare
Contributor
Author
Contributor
|
/cc @mbohlool |
Contributor
|
/cc @wenjiaswe |
Contributor
|
/assign |
k8s-ci-robot
added
the
needs-rebase
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/response.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/response.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/response.go
Outdated
Show resolved
Hide resolved
smarterclayton
force-pushed
the
watch_converted
branch
from
c4b3391 to
280c346
Compare
k8s-ci-robot
added
size/L
smarterclayton
force-pushed
the
watch_converted
branch
from
4c86aa1 to
857504b
Compare
Clean up the code paths that lead to objects being transformed and output with negotiation.
Remove some duplicate code that was not consistent. Now, watch will respond correctly to
Table and PartialObjectMetadata requests. Add unit and integration tests.
When transforming responses to Tables, only the first watch event for a given type will
include the columns. Columns will not change unless the watch is restarted.
Add a volume attachment printer and tighten up table validation error cases.
Disable protobuf from table conversion because Tables don't have protobuf because they
use `interface{}`
smarterclayton
force-pushed
the
watch_converted
branch
from
857504b to
3230a0b
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Member
|
This lgtm. I'm inclined to hold it for 1.15 at this point. |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/remove-label api-review |
k8s-ci-robot
removed
the
api-review
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
|
does this PR also fix the issue #62175 was trying to address? |
|
/retest Review the full test history for this PR. Silence the bot with an |
Contributor
Author
|
As commented on slack, there is a separate PR that resolves it that
simplifies the client code - Fix watch negotiation when using a non-default
mime type in the client
<#73938>
I want to look as well at fixing the CRD clients to bypass protobuf if the
provided object can't be encoded into protobuf on update operations, which
would allow us to default to protobuf clients.
…On Tue, Mar 19, 2019 at 11:01 PM fejta-bot ***@***.***> wrote:
/retest
This bot automatically retries jobs that failed/flaked on approved PRs
(send feedback to fejta <https://github.com/fejta>).
Review the full test history <https://gubernator.k8s.io/pr/71548> for
this PR.
Silence the bot with an /lgtm cancel or /hold comment for consistent
failures.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#71548 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p2XrIDn-Ikg7hLXzkw0oigKLgb3iks5vYaR2gaJpZM4Y48S1>
.
|
christarazi
added a commit
to christarazi/cilium
that referenced
this pull request
Oct 15, 2020
The ability to watch metav1.PartialObjectMetadata (or POM) and metav1.Table was introduced in K8s 1.15. [1] This is relevant because our CRD controller attempts to fetch CRDs in the cluster efficiently by requesting the CRD in a POM object. The CRD controller does this in order to avoid requesting the full object, which may contain a large validation schema and other irrelevant fields. This is important because in large-scale environments, all agents will request all the CRDs at once which will put unnecessary load on the apiserver. However, we cannot perform this request at all on versions of K8s 1.14 and below. Therefore, we must fullback to requesting the full CRD object. Hence, this commit allows us to check whether the apiserver supports this action, so that we can efficiently request CRDs on versions that do support it. [1]: KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190322-server-side-get-to-ga.md#goals [1]: PR: kubernetes/kubernetes#71548 Signed-off-by: Chris Tarazi <chris@isovalent.com>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Oct 15, 2020
The ability to watch metav1.PartialObjectMetadata (or POM) and metav1.Table was introduced in K8s 1.15. [1] This is relevant because our CRD controller attempts to fetch CRDs in the cluster efficiently by requesting the CRD in a POM object. The CRD controller does this in order to avoid requesting the full object, which may contain a large validation schema and other irrelevant fields. This is important because in large-scale environments, all agents will request all the CRDs at once which will put unnecessary load on the apiserver. However, we cannot perform this request at all on versions of K8s 1.14 and below. Therefore, we must fullback to requesting the full CRD object. Hence, this commit allows us to check whether the apiserver supports this action, so that we can efficiently request CRDs on versions that do support it. [1]: KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190322-server-side-get-to-ga.md#goals [1]: PR: kubernetes/kubernetes#71548 Signed-off-by: Chris Tarazi <chris@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the code paths that lead to objects being transformed and output
with negotiation. Remove some duplicate code that was not consistent. Now,
watch will respond correctly to Table and PartialObjectMetadata requests.
/kind bug
TODO