Skip to content

Support Table and PartialObjectMetadata on watch - #71548

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
smarterclayton:watch_converted
Mar 20, 2019
Merged

k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
smarterclayton:watch_converted

Conversation

@smarterclayton

@smarterclayton smarterclayton commented Nov 29, 2018 •

Copy link
Copy Markdown
Contributor

Clean up the code paths that lead to objects being transformed and output
with negotiation. Remove some duplicate code that was not consistent. Now,
watch will respond correctly to Table and PartialObjectMetadata requests.

/kind bug

TODO

  • Add unit tests
  • Add e2e test
  • Only return Table headers on the first object
  • During early output negotiation, filter unsupported encodings
Watch will now support converting response objects into Table or PartialObjectMetadata forms.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 29, 2018
@smarterclayton

Copy link
Copy Markdown
Contributor Author

/assign @liggitt

First two commits are from #71542

@fedebongio

Copy link
Copy Markdown
Contributor

/cc @mbohlool

@fedebongio

Copy link
Copy Markdown
Contributor

/cc @wenjiaswe

@caesarxuchao

Copy link
Copy Markdown
Contributor

/assign

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 28, 2018
@liggitt

liggitt commented Mar 8, 2019

Copy link
Copy Markdown
Member

I can take your patch for partial negotiation.

yeah, I updated it at https://github.com/liggitt/kubernetes/commits/not-acceptable

@smarterclayton
smarterclayton force-pushed the watch_converted branch 2 times, most recently from 4c86aa1 to 857504b Compare March 8, 2019 16:53
Clean up the code paths that lead to objects being transformed and output with negotiation.
Remove some duplicate code that was not consistent. Now, watch will respond correctly to
Table and PartialObjectMetadata requests. Add unit and integration tests.

When transforming responses to Tables, only the first watch event for a given type will
include the columns. Columns will not change unless the watch is restarted.

Add a volume attachment printer and tighten up table validation error cases.

Disable protobuf from table conversion because Tables don't have protobuf because they
use `interface{}`
@smarterclayton

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@smarterclayton

Copy link
Copy Markdown
Contributor Author

/retest

@liggitt

liggitt commented Mar 12, 2019

Copy link
Copy Markdown
Member

This lgtm. I'm inclined to hold it for 1.15 at this point.

@liggitt

liggitt commented Mar 12, 2019

Copy link
Copy Markdown
Member

/lgtm
/approve
/milestone v1.15

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Mar 12, 2019
@liggitt

liggitt commented Mar 12, 2019

Copy link
Copy Markdown
Member

/remove-label api-review

@k8s-ci-robot k8s-ci-robot removed the api-review Categorizes an issue or PR as actively needing an API review. label Mar 12, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

liggitt commented Mar 12, 2019

Copy link
Copy Markdown
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2019
@liggitt

liggitt commented Mar 15, 2019

Copy link
Copy Markdown
Member

does this PR also fix the issue #62175 was trying to address?

@fejta-bot

Copy link
Copy Markdown

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@smarterclayton

smarterclayton commented Mar 20, 2019 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants