Support Table and PartialObjectMetadata on watch #71548
Clean up the code paths that lead to objects being transformed and output
Nov 29, 2018
Dec 28, 2018
Mar 8, 2019
on master, this works:
curl 'http://localhost:8080/api/v1/namespaces' -H "Accept: application/yaml;as=Table;v=v1beta1;g=meta.k8s.io"
apiVersion: meta.k8s.io/v1beta1 kind: Table metadata: resourceVersion: "327" selfLink: /api/v1/namespaces columnDefinitions: - description: 'Name must be unique within a namespace. Is required when creating resources, although some resources may allow a client to request the generation of an appropriate name automatically. Name is primarily intended for creation idempotence and configuration definition. Cannot be updated. More info: http://kubernetes.io/docs/user-guide/identifiers#names' format: name name: Name priority: 0 type: string - description: The status of the namespace format: "" name: Status priority: 0 type: string - description: |- CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC. Populated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata format: "" name: Age priority: 0 type: string rows: ...
on this branch:
for non-watch, we need coverage of the content types we currently support
yeah, I updated it at https://github.com/liggitt/kubernetes/commits/not-acceptable
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
As commented on slack, there is a separate PR that resolves it that simplifies the client code - Fix watch negotiation when using a non-default mime type in the client <#73938> I want to look as well at fixing the CRD clients to bypass protobuf if the provided object can't be encoded into protobuf on update operations, which would allow us to default to protobuf clients.…
On Tue, Mar 19, 2019 at 11:01 PM fejta-bot ***@***.***> wrote: /retest This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta <https://github.com/fejta>). Review the full test history <https://gubernator.k8s.io/pr/71548> for this PR. Silence the bot with an /lgtm cancel or /hold comment for consistent failures. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#71548 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p2XrIDn-Ikg7hLXzkw0oigKLgb3iks5vYaR2gaJpZM4Y48S1> .