Repository navigation
Support Table and PartialObjectMetadata on watch - #71548
Conversation
1ec127a to
c4b3391
Compare
|
/cc @mbohlool |
|
/cc @wenjiaswe |
|
/assign |
c4b3391 to
280c346
Compare
yeah, I updated it at https://github.com/liggitt/kubernetes/commits/not-acceptable |
4c86aa1 to
857504b
Compare
Clean up the code paths that lead to objects being transformed and output with negotiation.
Remove some duplicate code that was not consistent. Now, watch will respond correctly to
Table and PartialObjectMetadata requests. Add unit and integration tests.
When transforming responses to Tables, only the first watch event for a given type will
include the columns. Columns will not change unless the watch is restarted.
Add a volume attachment printer and tighten up table validation error cases.
Disable protobuf from table conversion because Tables don't have protobuf because they
use `interface{}`
857504b to
3230a0b
Compare
|
/retest |
1 similar comment
|
/retest |
|
This lgtm. I'm inclined to hold it for 1.15 at this point. |
|
/lgtm |
|
/remove-label api-review |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
does this PR also fix the issue #62175 was trying to address? |
|
/retest Review the full test history for this PR. Silence the bot with an |
|
As commented on slack, there is a separate PR that resolves it that
simplifies the client code - Fix watch negotiation when using a non-default
mime type in the client
<#73938>
I want to look as well at fixing the CRD clients to bypass protobuf if the
provided object can't be encoded into protobuf on update operations, which
would allow us to default to protobuf clients.
…On Tue, Mar 19, 2019 at 11:01 PM fejta-bot ***@***.***> wrote:
/retest
This bot automatically retries jobs that failed/flaked on approved PRs
(send feedback to fejta <https://github.com/fejta>).
Review the full test history <https://gubernator.k8s.io/pr/71548> for
this PR.
Silence the bot with an /lgtm cancel or /hold comment for consistent
failures.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#71548 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p2XrIDn-Ikg7hLXzkw0oigKLgb3iks5vYaR2gaJpZM4Y48S1>
.
|
Clean up the code paths that lead to objects being transformed and output
with negotiation. Remove some duplicate code that was not consistent. Now,
watch will respond correctly to Table and PartialObjectMetadata requests.
/kind bug
TODO