New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default etcd server to 3.3.10 for kubernetes 1.14 #71615

Merged
merged 1 commit into from Dec 4, 2018

Conversation

@jpbetz
Copy link
Contributor

jpbetz commented Nov 30, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Update default etcd server to 3.3.10 for kubernetes 1.14. etcd client was previously upgraded to 3.3.10 for kubernetes 1.14.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #61326

Special notes for your reviewer:

For reference, previous bump to 3.2.24 was performed using #68318, #68898, #68901 and #9675

Does this PR introduce a user-facing change?:

Upgrade default etcd server to 3.3.10

cc @timstclair
/sig api-machinery
/area etcd

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Nov 30, 2018

Images have been published to gcr.io/k8s-image-staging and will shortly be promoted to http://k8s.gcr.io.

@jpbetz jpbetz referenced this pull request Nov 30, 2018

Closed

Bump etcd to 3.3 #61326

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 30, 2018

is this targeting 1.13.1?

@jpbetz jpbetz changed the title Update default etcd server to 3.3.10 for kubernetes 1.13 Update default etcd server to 3.3.10 for kubernetes 1.14 Nov 30, 2018

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Nov 30, 2018

@liggitt No, sorry, I had an off-by-one error in my k8s versions. This is targeting 1.14 with no plan to cherrypick to previous releases. I've updated the title and description to match.

@jpbetz jpbetz modified the milestones: v1.13, v1.14 Nov 30, 2018

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Nov 30, 2018

Images published.

/retest

@jpbetz jpbetz force-pushed the jpbetz:etcd-3.3.10-0-image branch from 43ca70b to f685e5f Nov 30, 2018

@luxas

This comment has been minimized.

Copy link
Member

luxas commented Dec 3, 2018

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Dec 3, 2018

/cc
/assign @timothysc

@timothysc
Copy link
Member

timothysc left a comment

/approve

Please address @luxas 's comments below.

@timothysc

This comment has been minimized.

Copy link
Member

timothysc commented Dec 3, 2018

/hold

@luxas please un-hold when lgtm.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jpbetz, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpbetz jpbetz force-pushed the jpbetz:etcd-3.3.10-0-image branch from f685e5f to 4128892 Dec 3, 2018

@luxas

luxas approved these changes Dec 3, 2018

Copy link
Member

luxas left a comment

LGTM, just one nit
/hold cancel
The kubeadm and build parts looks good, not familiar with the GKE part.

Meta: we should be able to remove the v2 upgrade/rollback code

@@ -388,6 +387,7 @@ var (
11: "3.2.18",

This comment has been minimized.

@luxas

luxas Dec 3, 2018

Member

Nit: you may remove the 10 and 11 statements, they're not used anymore

This comment has been minimized.

@jpbetz

jpbetz Dec 3, 2018

Contributor

Removed

@jpbetz jpbetz force-pushed the jpbetz:etcd-3.3.10-0-image branch 2 times, most recently from 04cc0b6 to fb9be5e Dec 3, 2018

@jpbetz jpbetz force-pushed the jpbetz:etcd-3.3.10-0-image branch from fb9be5e to 862b945 Dec 3, 2018

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Dec 3, 2018

@luxas Removing 1.10 and 1.11 k8s versions from kubeadm test constants broke a variety of tests in ways that were not entirely obvious to me how to fix. I've put the old versions back in the PR for now. Let's open a separate issue to remove them.

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Dec 3, 2018

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Dec 3, 2018

/retest

2 similar comments
@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Dec 4, 2018

/retest

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Dec 4, 2018

/retest

@luxas

This comment has been minimized.

Copy link
Member

luxas commented Dec 4, 2018

@luxas Removing 1.10 and 1.11 k8s versions from kubeadm test constants broke a variety of tests in ways that were not entirely obvious to me how to fix. I've put the old versions back in the PR for now. Let's open a separate issue to remove them.

Ok, np!

@luxas

luxas approved these changes Dec 4, 2018

Copy link
Member

luxas left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 4, 2018

@k8s-ci-robot k8s-ci-robot merged commit a9b69dc into kubernetes:master Dec 4, 2018

18 checks passed

cla/linuxfoundation jpbetz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

dims added a commit to dims/openlab-zuul-jobs that referenced this pull request Dec 4, 2018

Update to etcd 3.3.10
k/k has now moved to 3.3.10 of etcd
kubernetes/kubernetes#71615

Change-Id: I450b3aff33235cc9d0d2abe5290f7c0cdf422f20

@dims dims referenced this pull request Dec 4, 2018

Merged

Update to etcd 3.3.10 #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment