New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to build docker images offline (do not always use `docker build --pull`) #71634

Merged
merged 1 commit into from Dec 5, 2018

Conversation

@ereslibre
Contributor

ereslibre commented Dec 1, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
Passing KUBE_BUILD_PULL_LATEST_IMAGES=n will disable building the artifacts
with --pull, so they can be built in an offline environment.

By default, KUBE_BUILD_PULL_LATEST_IMAGES is y, so the default behavior
is kept unchanged.

This allows to work on an offline environment when regenerating container images artifacts.

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 1, 2018

Hi @ereslibre. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from cblecker and jbeda Dec 1, 2018

@dims

This comment has been minimized.

Member

dims commented Dec 1, 2018

/ok-to-test

@ereslibre

This comment has been minimized.

Contributor

ereslibre commented Dec 1, 2018

/retest

@cblecker

I don't see any issue with this.

Show resolved Hide resolved build/lib/release.sh
@cblecker

This comment has been minimized.

Member

cblecker commented Dec 3, 2018

/sig release
/priority backlog

/cc @ixdy
Any reason for concern here, Jeff?

Allow to build docker images offline (do not always use `docker build…
… --pull`)

Passing `KUBE_BUILD_PULL_LATEST_IMAGES=n` will disable building the artifacts
with `--pull`, so they can be built in an offline environment.

By default, `KUBE_BUILD_PULL_LATEST_IMAGES` is `y`, so the default behavior
is kept unchanged.

@ereslibre ereslibre force-pushed the ereslibre:allow-to-build-images-offline branch from 12ebd6f to 68e6fa0 Dec 3, 2018

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Dec 3, 2018

@ereslibre

This comment has been minimized.

Contributor

ereslibre commented Dec 3, 2018

@cblecker Added the comment.

@cblecker

This comment has been minimized.

Member

cblecker commented Dec 3, 2018

/test pull-kubernetes-verify

@ereslibre

This comment has been minimized.

Contributor

ereslibre commented Dec 3, 2018

/retest

@ixdy

This comment has been minimized.

Member

ixdy commented Dec 5, 2018

I originally added this in #39695 because we were depending on things like debian:jessie or busybox:latest, so it was important to pull the latest image.

I think now we use explicit versions (and don't even use busybox at all in this flow), so we could even remove the --pull, but it's fine to leave it too.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 5, 2018

@cblecker

This comment has been minimized.

Member

cblecker commented Dec 5, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ereslibre, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e689d51 into kubernetes:master Dec 5, 2018

18 checks passed

cla/linuxfoundation ereslibre authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@ereslibre ereslibre deleted the ereslibre:allow-to-build-images-offline branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment