Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for waiting by label selector or on all resources #71746
What type of PR is this?
What this PR does / why we need it:
Will add support for
Which issue(s) this PR fixes:
Special notes for your reviewer:
apiVersion: v1 kind: Namespace metadata: name: test --- apiVersion: extensions/v1beta1 kind: Deployment metadata: name: test namespace: test spec: replicas: 2 template: metadata: labels: app: test spec: containers: - name: echo image: busybox:latest command: - sleep - "3600"
Does this PR introduce a user-facing change?:
Hi @rctl. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
@rctl: Those labels are not set on the issue:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.