New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #71597: Add additional err check for cloudProvider.InstanceNotFound #71756

Merged
merged 1 commit into from Dec 10, 2018

Conversation

@marc-sensenich
Contributor

marc-sensenich commented Dec 5, 2018

Cherry pick of #71597 on release-1.12.

#71597: Add additional err check for cloudProvider.InstanceNotFound

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 5, 2018

Hi @marc-sensenich. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marc-sensenich

This comment has been minimized.

Contributor

marc-sensenich commented Dec 5, 2018

/sig azure

@marc-sensenich

This comment has been minimized.

Contributor

marc-sensenich commented Dec 5, 2018

/assign @feiskyer

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 6, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 6, 2018

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 6, 2018

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, marc-sensenich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 6, 2018

/kind bug
/priority critical-urgent

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 6, 2018

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 6, 2018

@marc-sensenich

This comment has been minimized.

Contributor

marc-sensenich commented Dec 6, 2018

/retest

@marc-sensenich marc-sensenich reopened this Dec 6, 2018

@marc-sensenich marc-sensenich force-pushed the marc-sensenich:automated-cherry-pick-of-#71597-upstream-release-1.12 branch from 844b695 to ce2f430 Dec 6, 2018

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 8, 2018

/retest

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 8, 2018

/test

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 9, 2018

/retest

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 10, 2018

@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 10, 2018

/retest

1 similar comment
@feiskyer

This comment has been minimized.

Member

feiskyer commented Dec 10, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 72722ba into kubernetes:release-1.12 Dec 10, 2018

16 of 18 checks passed

pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation marc-sensenich authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 10, 2018

@marc-sensenich: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big ce2f430 link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment