Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement request cancellation in token transport #71757

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@mikedanese
Copy link
Member

commented Dec 5, 2018

Noticed in kubernetes/client-go#527 although I'm not certain if it's the root cause yet.

/kind bug
/sig auth

Implement request cancellation in token transport to get rid of warnings when the HTTP client tries to cancel a request.
@lavalamp

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

/assign @yliaog

@mikedanese mikedanese force-pushed the mikedanese:fixcancel branch from 7494bac to 3addb22 Dec 7, 2018

@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Dec 7, 2018

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@mikedanese mikedanese force-pushed the mikedanese:fixcancel branch from 3addb22 to 7beea83 May 4, 2019

@mikedanese

This comment has been minimized.

Copy link
Member Author

commented May 4, 2019

@yliaog Done.

@mikedanese mikedanese force-pushed the mikedanese:fixcancel branch 2 times, most recently from 7276fed to 41bcc97 May 4, 2019

@mikedanese mikedanese force-pushed the mikedanese:fixcancel branch from 41bcc97 to 5990fea Jun 12, 2019

@mikedanese mikedanese force-pushed the mikedanese:fixcancel branch from 5990fea to 5f7f7c0 Aug 15, 2019

@mikedanese

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@liggitt @yliaog PTAL. This fixes a sig-auth bug where kubectl is spitting out gross error logs.

@mikedanese mikedanese force-pushed the mikedanese:fixcancel branch from 5f7f7c0 to 293cd9c Aug 15, 2019

Header: test.header,
})

if baseRecorder.canceled == false {

This comment has been minimized.

Copy link
@yliaog

yliaog Aug 15, 2019

Contributor

could you add a test case 'unable to cancel request'?

This comment has been minimized.

Copy link
@mikedanese

mikedanese Aug 16, 2019

Author Member

Done.

@mikedanese mikedanese force-pushed the mikedanese:fixcancel branch from 293cd9c to a42e029 Aug 16, 2019

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 16, 2019

@mikedanese

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikedanese

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 20, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

@mikedanese: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 3addb22 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikedanese

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

/retest

1 similar comment
@mikedanese

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit bc1d8c6 into kubernetes:master Aug 20, 2019

23 checks passed

cla/linuxfoundation mikedanese authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 20, 2019

@mikedanese mikedanese deleted the mikedanese:fixcancel branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.