New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all new API versions of resources default to DeleteDependents #71792

Merged
merged 1 commit into from Dec 8, 2018

Conversation

@liggitt
Member

liggitt commented Dec 6, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

For compatibility, resources with dependents that existed prior to server-side garbage collection default to orphaning dependents when deleted.

This PR sweeps the strategies for those resources and ensures that any future API versions introduced will default to using server-side garbage collection.

Which issue(s) this PR fixes:
xref #71772

Special notes for your reviewer:

Best viewed ignoring whitespace

Does this PR introduce a user-facing change?:

NONE
@liggitt

This comment has been minimized.

Member

liggitt commented Dec 6, 2018

/sig api-machinery
/priority important-longterm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Member

liggitt commented Dec 6, 2018

/retest

@soltysh

soltysh approved these changes Dec 6, 2018

/lgtm

@fejta-bot

This comment has been minimized.

fejta-bot commented Dec 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot

This comment has been minimized.

fejta-bot commented Dec 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

fejta-bot commented Dec 7, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@liggitt liggitt force-pushed the liggitt:gc-defaults branch from 654c237 to a215829 Dec 7, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 7, 2018

@liggitt liggitt force-pushed the liggitt:gc-defaults branch from a215829 to 3b099dd Dec 7, 2018

@liggitt

This comment has been minimized.

Member

liggitt commented Dec 7, 2018

fixed unit tests

@liggitt

This comment has been minimized.

Member

liggitt commented Dec 7, 2018

/retest

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Dec 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 7, 2018

@fejta-bot

This comment has been minimized.

fejta-bot commented Dec 8, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 52705de into kubernetes:master Dec 8, 2018

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment