New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage collect LB resources for GCE #71812

Open
wants to merge 1 commit into
base: master
from

Conversation

@anfernee
Member

anfernee commented Dec 6, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
To clean up orphan LB resources in GCE

NONE
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 6, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anfernee
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gmarek

If they are not already assigned, you can assign the PR to them by writing /assign @gmarek in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bowei and vishh Dec 6, 2018

@anfernee

This comment has been minimized.

Member

anfernee commented Dec 6, 2018

@rramkumar1 Still WIP, 'cause I think I miss some resources in it.

gcloud compute --project=${PROJECT} target-pools delete "${x}" --region=${REGION} -q
result=1
fi
if ! gcloud compute --project=${PROJECT} target-pools get-health "${x}" --region=${REGION} 2>/dev/null >/dev/null; then

This comment has been minimized.

@rramkumar1

rramkumar1 Dec 6, 2018

Member

Can you add some comments here? Its hard to follow the logic.

This comment has been minimized.

@anfernee

anfernee Dec 7, 2018

Member

added comments.

@anfernee anfernee force-pushed the anfernee:clean-script branch 2 times, most recently from 167daac to 04f5542 Dec 7, 2018

@anfernee anfernee force-pushed the anfernee:clean-script branch from 04f5542 to 6ac2fc1 Dec 7, 2018

PROJECT=${PROJECT:-kubernetes-jenkins}
REGION=${REGION:-us-central1}
# Deleting external load balancer resources

This comment has been minimized.

@rramkumar1

rramkumar1 Dec 7, 2018

Member

This is external L4 right?

This comment has been minimized.

@anfernee

anfernee Dec 7, 2018

Member

yes. basically it's the gce resources created when user creates an external k8s LB.

fi
done
# Deleting internal load balancer resources

This comment has been minimized.

@rramkumar1

rramkumar1 Dec 7, 2018

Member

This is external L7 right?

This comment has been minimized.

@anfernee

anfernee Dec 7, 2018

Member

It's an internal L4.

@anfernee

This comment has been minimized.

Member

anfernee commented Dec 7, 2018

/test pull-kubernetes-e2e-kops-aws

@rramkumar1

This comment has been minimized.

Member

rramkumar1 commented Dec 7, 2018

/lgtm

@anfernee

This comment has been minimized.

Member

anfernee commented Dec 10, 2018

cc @bowei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment