New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look up service accounts from informer before trying live lookup #71816

Merged
merged 1 commit into from Jan 1, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Dec 6, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:

Makes the service account authenticator used informers to get pod/secret/serviceaccount data, and only fall back to live lookups if the data is not found in the informer

Which issue(s) this PR fixes:
Fixes #71811

Does this PR introduce a user-facing change?:

kube-apiserver: improves performance of requests made with service account token authentication

/cc @mikedanese

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 6, 2018

/sig auth

@liggitt liggitt force-pushed the liggitt:service-account-lookup branch from 76d2be3 to a9dc919 Dec 6, 2018

@k8s-ci-robot k8s-ci-robot added size/L sig/testing and removed size/S labels Dec 6, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 6, 2018

/retest

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 26, 2018

/assign @mikedanese

@ash2k

This comment has been minimized.

Copy link
Member

ash2k commented Jan 1, 2019

This PR looks good to me, so I'm going to lgtm. I hope this is fine and I'm not "breaking" the review process in some way. Please let me know if I shouldn't have done it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 1, 2019

@ash2k

This comment has been minimized.

Copy link
Member

ash2k commented Jan 1, 2019

/retest pull-kubernetes-godeps

@ash2k

This comment has been minimized.

Copy link
Member

ash2k commented Jan 1, 2019

/test pull-kubernetes-godeps

@k8s-ci-robot k8s-ci-robot merged commit 6e182ed into kubernetes:master Jan 1, 2019

19 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:service-account-lookup branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment