New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scheduler cleanup phase 2]: Rename `pkg/scheduler/cache` to `pkg/scheduler/nodeinfo` #71872

Merged
merged 2 commits into from Dec 12, 2018

Conversation

@yuexiao-wang
Copy link
Contributor

yuexiao-wang commented Dec 8, 2018

Signed-off-by: yuexiao-wang wang.yuexiao@zte.com.cn

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Nearly all of the "cache" functionality has been moved from this package into pkg/scheduler/internal/cache.
Rename pkg/scheduler/cache to pkg/scheduler/nodeinfo

Which issue(s) this PR fixes:

Fixes # #71862

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 8, 2018

Hi @yuexiao-wang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuexiao-wang

This comment has been minimized.

Copy link
Contributor

yuexiao-wang commented Dec 8, 2018

@yagonobre
Copy link
Member

yagonobre left a comment

Thanks @yuexiao-wang
/ok-to-test

@yuexiao-wang

This comment has been minimized.

Copy link
Contributor

yuexiao-wang commented Dec 8, 2018

@yagonobre Thanks

@yuexiao-wang

This comment has been minimized.

Copy link
Contributor

yuexiao-wang commented Dec 8, 2018

/test pull-kubernetes-integration

@yuexiao-wang

This comment has been minimized.

Copy link
Contributor

yuexiao-wang commented Dec 8, 2018

/test pull-kubernetes-e2e-gce-100-performance

@wgliang

This comment has been minimized.

Copy link
Member

wgliang commented Dec 8, 2018

Just a rename action.
/lgtm
thanks @yuexiao-wang

@bsalamat
Copy link
Contributor

bsalamat left a comment

/lgtm
/approve

@misterikkit
Copy link
Contributor

misterikkit left a comment

Looks like you need to update the package statements inside the new package.

@yuexiao-wang yuexiao-wang force-pushed the yuexiao-wang:scheduler-nodeinfo branch from fc34f8d to b7a7e5c Dec 11, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 11, 2018

@yuexiao-wang yuexiao-wang force-pushed the yuexiao-wang:scheduler-nodeinfo branch 2 times, most recently from 33539d9 to 7b6f60f Dec 11, 2018

yuexiao-wang added some commits Dec 8, 2018

[scheduler cleanup phase 2]: Rename to
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
modify BUILD
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
@yuexiao-wang

This comment has been minimized.

Copy link
Contributor

yuexiao-wang commented Dec 11, 2018

/test pull-kubernetes-verify

@yuexiao-wang

This comment has been minimized.

Copy link
Contributor

yuexiao-wang commented Dec 11, 2018

I have updated the packag statements inside the new packages.
@misterikkit @bsalamat @wgliang PTAL

@wgliang

This comment has been minimized.

Copy link
Member

wgliang commented Dec 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 11, 2018

@misterikkit

This comment has been minimized.

Copy link
Contributor

misterikkit commented Dec 12, 2018

/lgtm

With so many people at kubecon, it may be difficult to get approvers for the other packages.

@wojtek-t Would you be willing to use your global approve powers on this mechanical name change PR?

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Dec 12, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, wojtek-t, yuexiao-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 05183bf into kubernetes:master Dec 12, 2018

18 checks passed

cla/linuxfoundation yuexiao-wang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment