Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: use DefValue for the --kubeconfig flag #71874
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
As far as I'm concerned the main use case for kubeadm is to take care of the node that exist locally on the machine.
The kubeconfig path should be considered only in few utilities command that the users might run on its own (without a node on the machine) e.g.
@neolit123 I start getting the impression that changing this without a master plan in the background that considers all the kubeadm commands is potentially risky
Prior art: after discussion with @luxas and you when implementing #70763, using KUBECONFIG first was dropped because of the potential risks, and as a consequence the current behavior for
Now we are changing opinion for
i'm mostly indifferent about the search order myself.
the cross linked issue is about
we can also ask the #kubeadm channel with a vote.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: neolit123
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
updated this PR to only remove the search precedence on
search precedence might make sense for these.
current precedence for the above commands:
this issue is about the precedence not accepting the user provided flag if it's the default value:
referenced this pull request
Feb 3, 2019
Feb 16, 2019
summary of how kubeconfig loading works currently:
i don't think i can improve the logic more here, so let's try to settle on a decision for 1.14.