New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gce cloud provider #72038

Merged
merged 8 commits into from Dec 19, 2018

Conversation

@bowei
Copy link
Member

bowei commented Dec 14, 2018

Changes the GCE cloud provider code to point to the vendored generated code.
This makes it easier to separate out the guts of the implementation of the cloud
provider from the shim that is used to connect the cloud provider with k8s.

NOTE: there are no logic changes, this simply takes the generate code and points it
at the external source.

NONE
@bowei

This comment has been minimized.

Copy link
Member

bowei commented Dec 14, 2018

/assign @rramkumar1

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Dec 14, 2018

/sig gcp

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Dec 14, 2018

/sig cloud-provider

@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and jbeda Dec 14, 2018

@rramkumar1

This comment has been minimized.

Copy link
Member

rramkumar1 commented Dec 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 14, 2018

@rramkumar1

This comment has been minimized.

Copy link
Member

rramkumar1 commented Dec 14, 2018

/assign @cblecker

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Dec 14, 2018

/assign @cheftako

@bowei bowei force-pushed the bowei:change-gce-cloud-provider branch from b7763eb to dde2bc4 Dec 14, 2018

@bowei bowei force-pushed the bowei:change-gce-cloud-provider branch 3 times, most recently from 78bcd50 to 7b73982 Dec 14, 2018

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/L labels Dec 14, 2018

@bowei bowei force-pushed the bowei:change-gce-cloud-provider branch from 7b73982 to e8fe856 Dec 14, 2018

@bowei bowei force-pushed the bowei:change-gce-cloud-provider branch from ff72d2a to 4ffaf70 Dec 18, 2018

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Dec 18, 2018

/cc @freehan

@k8s-ci-robot k8s-ci-robot requested a review from freehan Dec 18, 2018

@freehan

This comment has been minimized.

Copy link
Member

freehan commented Dec 18, 2018

hack/verify-godeps.sh failed.

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Dec 18, 2018

/retest

1 similar comment
@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Dec 18, 2018

/retest

@freehan

This comment has been minimized.

Copy link
Member

freehan commented Dec 19, 2018

/lgtm
/kind cleanup

@freehan

This comment has been minimized.

Copy link
Member

freehan commented Dec 19, 2018

/assign @thockin for approval

@thockin
Copy link
Member

thockin left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, rramkumar1, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 00ca693 into kubernetes:master Dec 19, 2018

19 checks passed

cla/linuxfoundation bowei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@bowei bowei deleted the bowei:change-gce-cloud-provider branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment