Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Perform GCE master log rotation check every 5 minutes #72062
Reduce how often we check if logs in the master need to be rotate from 1hr to 5min. Rotation policy stays the same (new day starts, log file size > 100MB). When logs are extremely spammy, the logs can grow far beyond what the rotation policy intends, this helps keep them better in check.
What this PR does / why we need it:
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
@yguo0905 Yes, the intent here was to change it just for masters. But maybe we should cc someone on sig-node who might have an opinion if we should do something similar on node? Probably best to make it a separate PR at this point if they decide they want it.