New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote NodeLease to Beta and enable by default #72096

Merged
merged 1 commit into from Dec 17, 2018

Conversation

@wojtek-t
Copy link
Member

wojtek-t commented Dec 17, 2018

Ref #14733
Ref https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/0009-node-heartbeat.md

Running tests at scale confirms that the main (of reducing size of etcd) has been achieved.
Without this change: etcd DB size: ~2.2GB
With this change: etcd DB size: ~1.3GB

Note that the tests were run on 5k nodes, but pretty much without any images being present on the node. And the more images on the nodes exist, the bigger impact we will have.
So the impact here is; ~2x+

@kubernetes/sig-node-pr-reviews @kubernetes/sig-scalability-pr-reviews @kubernetes/sig-api-machinery-pr-reviews
@mtaufen @wangzhen127 @liggitt @dchen1107 @yujuhong @lavalamp @bgrant0607 @gmarek

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 17, 2018

@wojtek-t: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wojtek-t wojtek-t force-pushed the wojtek-t:promote_node_lease branch from e43c2b6 to 546ece7 Dec 17, 2018

@k8s-ci-robot k8s-ci-robot added size/S sig/auth and removed size/XS labels Dec 17, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Dec 17, 2018

/lgtm

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Dec 17, 2018

@k8s-ci-robot k8s-ci-robot merged commit f77a070 into kubernetes:master Dec 17, 2018

19 checks passed

cla/linuxfoundation wojtek-t authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@dchen1107

This comment has been minimized.

Copy link
Member

dchen1107 commented Dec 17, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment