Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch location for goautoneg vendored code #72138

Merged
merged 1 commit into from Jan 18, 2019

Conversation

@dims
Copy link
Member

commented Dec 18, 2018

Move to github.com/munnerz/goautoneg as bitbucket is flaky!

Change-Id: Iaa6e964ef0d6f308eea59bcc6f365ecd7dbf0784

What type of PR is this?

/kind flake

What this PR does / why we need it:

bitbucket is unreliable. same code has been in @munnerz 's repo for a while. let's switch to that

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@krzyzacy

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

qq: how does it work with vendor deps? assume we bump vendor next time it will come back?

@dims dims force-pushed the dims:switch-location-for-goautoneg branch from 5aba74c to 4bd5772 Dec 18, 2018

@dims

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2018

Need this to merge first - kubernetes/kube-openapi#126

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

/remove-sig api-machinery

@dims dims changed the title [WIP] Switch location for goautoneg vendored code Switch location for goautoneg vendored code Jan 15, 2019

@dims dims force-pushed the dims:switch-location-for-goautoneg branch from 4bd5772 to 1e18fd0 Jan 15, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

/priority important-soon

@dims

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

@dims dims force-pushed the dims:switch-location-for-goautoneg branch from 1e18fd0 to 17f6e61 Jan 16, 2019

Switch location for goautoneg vendored code
Move to github.com/munnerz/goautoneg as bitbucket is flaky!

Change-Id: Iaa6e964ef0d6f308eea59bcc6f365ecd7dbf0784

@dims dims force-pushed the dims:switch-location-for-goautoneg branch from 17f6e61 to 16fd72d Jan 16, 2019

@k8s-ci-robot k8s-ci-robot added size/XL and removed size/M labels Jan 16, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

/test pull-kubernetes-e2e-kops-aws

Show resolved Hide resolved Godeps/Godeps.json
Show resolved Hide resolved api/openapi-spec/swagger.json
@liggitt

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 18, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit ef2a5b9 into kubernetes:master Jan 18, 2019

18 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@@ -336,6 +336,7 @@ func (g openAPITypeWriter) generate(t *types.Type) error {
}
g.Do("return $.OpenAPIDefinition|raw${\nSchema: spec.Schema{\nSchemaProps: spec.SchemaProps{\n", args)
g.generateDescription(t.CommentLines)
g.Do("Type: []string{\"object\"},\n", nil)

This comment has been minimized.

Copy link
@sttts

sttts Feb 21, 2019

Contributor

this was an accident. Certainly has nothing to do with the actual PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.