Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ovirt/cloudstack/photon cloud providers #72178

Conversation

@dims
Copy link
Member

commented Dec 19, 2018

Change-Id: I7ae5332b3659a2acd3805a51686af7d06ff86f4e

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove deprecated cloud providers - ovirt, cloudstack and photon
@cblecker

This comment has been minimized.

Copy link
Member

commented Dec 19, 2018

/test pull-kubernetes-godeps

@dims dims force-pushed the dims:remove-ovirt-photon-cloudstack-cloud-providers branch from a661380 to 977c87a Dec 19, 2018

@dims dims force-pushed the dims:remove-ovirt-photon-cloudstack-cloud-providers branch from 977c87a to 08e08c9 Dec 19, 2018

@dims

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2018

/test pull-kubernetes-godeps

@dims

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2018

@dims dims added this to the v1.15 milestone Dec 19, 2018

@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

I'd love to see these go in 1.15, but if they were announced deprecated in 1.12, then 1.12 + 1 year ("Deprecated behaviors must function for no less than 1 year after their announced deprecation") means removing in 1.16, right?

@onitake

This comment has been minimized.

Copy link

commented May 29, 2019

Note: https://github.com/tsuru/custom-cloudstack-ccm is not a generic CloudStack CCM. See this issue: tsuru/custom-cloudstack-ccm#15

We made one that we think is better suited as a replacement for the old cloud provider: https://github.com/swisstxt/cloudstack-cloud-controller-manager

dims added some commits Jun 10, 2019

Remove ovirt/cloudstack/photon cloud providers
Change-Id: Iddb80bdc2a9d75d444b8a3cfe0b142acb78e9097
remove vendored code
Change-Id: I47de33db8e993b900efd3b00691325856e1d4f85

@dims dims force-pushed the dims:remove-ovirt-photon-cloudstack-cloud-providers branch from d8cb1a1 to bf76df3 Jun 10, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Jun 14, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, liggitt, neolit123, rhtyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

@dims: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized ab67c6b link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit c6bc163 into kubernetes:master Jun 14, 2019

21 of 23 checks passed

pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@dims dims referenced this pull request Jun 14, 2019

Merged

Update vendored dependencies to released version #78187

37 of 38 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.