New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Lease API to v1 #72239

Merged
merged 2 commits into from Dec 21, 2018

Conversation

@wojtek-t
Copy link
Member

wojtek-t commented Dec 20, 2018

Ref #14733

The `Lease` API type in the `coordination.k8s.io` API group is promoted to `v1`

@wojtek-t wojtek-t force-pushed the wojtek-t:v1_lease_api branch from 0a62ed0 to a89c2bc Dec 20, 2018

ExpectedEtcdPath: "/registry/leases/etcdstoragepathtestnamespace/lease1",
Stub: `{"metadata": {"name": "leasev1beta1"}, "spec": {"holderIdentity": "holder", "leaseDurationSeconds": 5}}`,
ExpectedEtcdPath: "/registry/leases/etcdstoragepathtestnamespace/leasev1beta1",
ExpectedGVK: gvkP("coordination.k8s.io", "v1", "Lease"),

This comment has been minimized.

@liggitt

liggitt Dec 20, 2018

Member

This must be stored in v1beta1 for one more release, so that HA upgrade and rollback is safe. ExpectedGVK for gvr("coordination.k8s.io", "v1", "leases") must be v1beta1

This comment has been minimized.

@wojtek-t
@@ -34,5 +35,6 @@ func init() {
func Install(scheme *runtime.Scheme) {
utilruntime.Must(coordination.AddToScheme(scheme))
utilruntime.Must(v1beta1.AddToScheme(scheme))
utilruntime.Must(scheme.SetVersionPriority(v1beta1.SchemeGroupVersion))
utilruntime.Must(v1.AddToScheme(scheme))
utilruntime.Must(scheme.SetVersionPriority(v1.SchemeGroupVersion, v1beta1.SchemeGroupVersion))

This comment has been minimized.

@liggitt

liggitt Dec 20, 2018

Member

prioritize v1beta1 over v1 for storage until v1 has been available for at least one release:

scheme.SetVersionPriority(v1beta1.SchemeGroupVersion, v1.SchemeGroupVersion)

This comment has been minimized.

@wojtek-t
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 20, 2018

doesn't need to be part of this PR, but are we planning to add support for Lease objects to the client-go leaderelection library?

@wojtek-t wojtek-t force-pushed the wojtek-t:v1_lease_api branch from a89c2bc to 798d7d6 Dec 20, 2018

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Dec 20, 2018

doesn't need to be part of this PR, but are we planning to add support for Lease objects to the client-go leaderelection library?

Yes - we should

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 20, 2018

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 20, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@wojtek-t wojtek-t force-pushed the wojtek-t:v1_lease_api branch from 798d7d6 to 9664779 Dec 20, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 20, 2018

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Dec 20, 2018

@liggitt - I just fixed the swagger-spec autogenerated part after switching the default storage format.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 20, 2018

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 21, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Dec 21, 2018

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 21, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 21, 2018

linking PR's that had a test flake because of #71696

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 21, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 5354f8b into kubernetes:master Dec 21, 2018

19 checks passed

cla/linuxfoundation wojtek-t authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment