Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Change docker metrics to conform metrics guidelines #72323
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
This patch does not remove the existing metrics but mark them as deprecated.
Does this PR introduce a user-facing change?:
What is the compatibility guarantee on metric names/values? Changing metrics this way with no advance notice is likely to cause problems with monitoring over upgrade boundaries. I'm not sure if this falls under an aspect of our deprecation policy that would require a longer pre-announce period, but if not, I'd advocate at least one release overlap where both old and new metrics are available.
These questions would be good to answer broadly and include in
referenced this pull request
Dec 26, 2018
2 similar comments
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here