Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change docker metrics to conform metrics guidelines #72323

Merged
merged 3 commits into from Feb 6, 2019

Conversation

@danielqsj
Copy link
Member

danielqsj commented Dec 25, 2018

What type of PR is this?

/sig instrumentation

What this PR does / why we need it:

  1. As part of kubernetes metrics overhaul, change docker metrics to conform Kubernetes metrics instrumentation guidelines.

  2. Change docker metrics to histogram for better aggregation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This patch does not remove the existing metrics but mark them as deprecated.
We need 2 releases for users to convert monitoring configuration.

Does this PR introduce a user-facing change?:

Change docker metrics to conform metrics guidelines and using histogram for better aggregation.
The following metrics are deprecated, and will be removed in a future release:
* `docker_operations`
* `docker_operations_latency_microseconds`
* `docker_operations_errors`
* `docker_operations_timeout`
* `network_plugin_operations_latency_microseconds`
Please convert to the following metrics:
* `docker_operations_total`
* `docker_operations_latency_seconds`
* `docker_operations_errors_total`
* `docker_operations_timeout_total`
* `network_plugin_operations_latency_seconds`

@danielqsj danielqsj changed the title Dockershim Change docker metrics to conform metrics guidelines Dec 25, 2018

@k8s-ci-robot k8s-ci-robot requested review from deads2k and rramkumar1 Dec 25, 2018

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Dec 25, 2018

/kind feature
/assign @brancz

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 26, 2018

What is the compatibility guarantee on metric names/values? Changing metrics this way with no advance notice is likely to cause problems with monitoring over upgrade boundaries. I'm not sure if this falls under an aspect of our deprecation policy that would require a longer pre-announce period, but if not, I'd advocate at least one release overlap where both old and new metrics are available.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 26, 2018

These questions would be good to answer broadly and include in
https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md to inform the other metrics updating efforts

@danielqsj danielqsj force-pushed the danielqsj:dockershim branch from d6d1395 to 474a5c6 Dec 26, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Dec 26, 2018

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Dec 26, 2018

@liggitt
Thanks, totally agree.
I already added the previous metrics back and marked them as deprecated.

@danielqsj danielqsj force-pushed the danielqsj:dockershim branch from 474a5c6 to 60bdda7 Dec 26, 2018

@danielqsj danielqsj force-pushed the danielqsj:dockershim branch from 11bcb74 to 65aec21 Dec 26, 2018

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Jan 8, 2019

Added Deprecated in metrics description. PTAL

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Jan 8, 2019

/retest

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Jan 8, 2019

@danielqsj could you open a PR against the metrics overhaul that says that the 1.14 release will have backward compatibility but 1.15 will drop the deprecated metrics and label? Thanks!

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Jan 8, 2019

/retest

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Jan 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 8, 2019

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Jan 8, 2019

/retest

2 similar comments
@brancz

This comment has been minimized.

Copy link
Member

brancz commented Jan 8, 2019

/retest

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Jan 10, 2019

/retest

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Jan 10, 2019

/assign @derekwaynecarr

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Jan 17, 2019

@derekwaynecarr can you help review this? Thanks

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Jan 21, 2019

@Random-Liu @sttts @deads2k if you have time, can you help review this? Thanks

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Jan 28, 2019

@danielqsj

This comment has been minimized.

Copy link
Member Author

danielqsj commented Feb 2, 2019

@thockin @derekwaynecarr @Random-Liu @sttts @deads2k if you have time, can you help review this? Thanks

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Feb 4, 2019

/assign @derekwaynecarr

for approval.

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Feb 5, 2019

/approve

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Feb 5, 2019

cc @deads2k @smarterclayton for test/OWNERS approval

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Feb 6, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielqsj, derekwaynecarr, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae45068 into kubernetes:master Feb 6, 2019

19 checks passed

cla/linuxfoundation danielqsj authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Context retired without replacement.
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.