Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourcequota: use dynamic informer #72384

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@zhouhaibing089
Copy link
Contributor

commented Dec 27, 2018

The resource quota controller should use a dynamic informer so it
can create informer for custom resources.

fixes #53777

A follow up on #64201.

Object count quota is now supported for namespaced custom resources using the `count/<resource>.<group>` syntax.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2018

Hi @zhouhaibing089. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2018

/ok-to-test

@zhouhaibing089 zhouhaibing089 force-pushed the zhouhaibing089:quota-crd branch 2 times, most recently from 852009a to 4278d2d Dec 27, 2018

@yue9944882

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

/hold
/cc @deads2k @p0lyn0mial @nikhita

not clear whether we still want to continue/rebase on #64201

@k8s-ci-robot k8s-ci-robot requested review from deads2k, nikhita and p0lyn0mial Dec 28, 2018

@zhouhaibing089 zhouhaibing089 force-pushed the zhouhaibing089:quota-crd branch from 4278d2d to b32e4d5 Dec 28, 2018

@zhouhaibing089 zhouhaibing089 force-pushed the zhouhaibing089:quota-crd branch from b32e4d5 to fdaea22 Dec 28, 2018

@zhouhaibing089

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

/assign @deads2k

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhouhaibing089 zhouhaibing089 force-pushed the zhouhaibing089:quota-crd branch from e2cff43 to 9257763 Mar 27, 2019

@zhouhaibing089

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Rebased and looking the e2e failure now.

@zhouhaibing089

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

I reproduced the failure locally, and the quota is not updated as I expect..

return false, err
}
// used may not yet be calculated
if resourceQuota.Status.Used == nil {

This comment has been minimized.

Copy link
@zhouhaibing089

zhouhaibing089 Mar 27, 2019

Author Contributor

Well, here is the bug, when status.used is nil, we should keep updating spec.hard.

resourcequota: use dynamic informer
The resource quota controller should use a dynamic informer so it
can create informer for custom resources.

@zhouhaibing089 zhouhaibing089 force-pushed the zhouhaibing089:quota-crd branch from 9257763 to f58c2ae Mar 27, 2019

@zhouhaibing089

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

All fixed.

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

/retest

@zhouhaibing089

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Looks like all the tests are green now.

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

/lgtm
/approve

@liggitt

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

/lgtm
/approve

Thanks for all the work on this

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yliaog, zhouhaibing089

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yliaog, zhouhaibing089

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhouhaibing089

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

/kind feature

@k8s-ci-robot k8s-ci-robot merged commit b9dbb45 into kubernetes:master Mar 27, 2019

17 checks passed

cla/linuxfoundation zhouhaibing089 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@zhouhaibing089 zhouhaibing089 deleted the zhouhaibing089:quota-crd branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.