Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up redundant conditiontype ‘OutOfDisk’ #72420

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@Pingan2017
Copy link
Member

commented Dec 29, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #48843

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The deprecated node condition type 'OutOfDisk' has been removed. Use the 'DiskPressure' condition instead.
@Pingan2017

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@Pingan2017

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

@k82cn

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

/approve for scheduler part

@timothysc
Copy link
Member

left a comment

This definitely needs a release note, b/c it's api facing.

@Pingan2017

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

This definitely needs a release note, b/c it's api facing.

Updated!

@timothysc

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

/lgtm

but this require @kubernetes/sig-api-machinery-pr-reviews approval.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 25, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented May 3, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@derekwaynecarr

This comment has been minimized.

Copy link
Member

commented May 3, 2019

If this was removed in 1.13, it should be fine to remove in 1.15, agree @liggitt?

@liggitt

This comment has been minimized.

Copy link
Member

commented May 4, 2019

1.15 only has to worry about nodes running >= 1.13, that is true.

however, since this is cleaning up node objects upgraded from 1.12 to 1.13+, the cleanup code needs to remain in place for 1.15, where no 1.12-level (or older) nodes are supported.

this can be dropped in 1.16.

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 3, 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@Pingan2017

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

/remove-lifecycle rotten

@zhanghuidinah

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

ping,any update?

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

/hold cancel

once rebased, this can be merged

@Pingan2017 Pingan2017 force-pushed the Pingan2017:cleanup-outofdisk branch from a25b2f8 to b62b7b7 Jul 3, 2019

@Pingan2017

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

rebased and remove func RemoveOutOfDiskCondition()

@liggitt @derekwaynecarr

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

@Pingan2017: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized a25b2f8 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 3, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@Pingan2017 Pingan2017 force-pushed the Pingan2017:cleanup-outofdisk branch from b62b7b7 to e94d7b3 Jul 3, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, liggitt, Pingan2017

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2a82853 into kubernetes:master Jul 3, 2019

22 of 23 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation Pingan2017 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@Pingan2017 Pingan2017 deleted the Pingan2017:cleanup-outofdisk branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.