Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Create the k8s.io/component-base staging repo #72569
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
@thockin exactly right. Only moving
I'll fix @sttts comments and squash to the final form. Thanks everybody for the reviews!
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
One small nit: can you add component-base to the list of staging repos in the README here: https://github.com/kubernetes/kubernetes/tree/master/staging?
On Tue, 8 Jan 2019 at 1:52 PM, Kubernetes Prow Robot < ***@***.***> wrote: @luxas <https://github.com/luxas>: The following test *failed*, say /retest to rerun them all: Test name Commit Details Rerun command pull-kubernetes-integration 1edd272 <1edd272> link <https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72569/pull-kubernetes-integration/40458/> /test pull-kubernetes-integration Full PR test history <https://gubernator.k8s.io/pr/72569>. Your PR dashboard <https://gubernator.k8s.io/pr/luxas>. Please help us cut down on flakes by linking to <https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#72569 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APXA0O2KFSe2R1S0BGCEoL5HvozgnARMks5vBFVjgaJpZM4Zpkvv> .