New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default maximumLoadBalancerRuleCount to 250 #72621

Merged
merged 1 commit into from Jan 7, 2019

Conversation

@feiskyer
Copy link
Member

feiskyer commented Jan 7, 2019

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

According to https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#load-balancer, the default limit of rules count per resource (Basic) is 250.

This PR increases maximumLoadBalancerRuleCount to 250.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Increase Azure default maximumLoadBalancerRuleCount to 250.

/sig azure
/assign @andyzhangx
cc @weinong

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Jan 7, 2019

/priority important-soon

@andyzhangx
Copy link
Member

andyzhangx left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 7, 2019

backoffDurationDefault = 5 // in seconds
backoffJitterDefault = 1.0
// According to https://docs.microsoft.com/en-us/azure/azure-subscription-service-limits#load-balancer.
maximumLoadBalancerRuleCount = 250

This comment has been minimized.

@krmayankk

krmayankk Jan 7, 2019

Contributor

Is this one to one mapping with a K8s service of type LoadBalancer ?

This comment has been minimized.

@feiskyer

feiskyer Jan 7, 2019

Member

one to one, or one to many. e.g. if service tags or loadBalancerSourceRanges are set, multiple rules would be created for the service

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Jan 7, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8b3b5a9 into kubernetes:master Jan 7, 2019

19 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@feiskyer feiskyer deleted the feiskyer:lb-rules-count branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment