New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ResourceQuotaSelector out of validation #72664

Merged
merged 1 commit into from Jan 8, 2019

Conversation

@sbezverk
Copy link
Contributor

sbezverk commented Jan 7, 2019

Signed-off-by: Serguei Bezverkhi sbezverk@cisco.com

xref: #72651

None

/release-note-none
/sig api-machinery

@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 7, 2019

/assign @liggitt

@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 8, 2019

/test pull-kubernetes-integration

limitations under the License.
*/

package resource

This comment has been minimized.

@liggitt

liggitt Jan 8, 2019

Member

let's put these in a resourcequota package

This comment has been minimized.

@sbezverk

sbezverk Jan 8, 2019

Author Contributor

done

func TestDropDisabledFields(t *testing.T) {
scopes := []api.ResourceQuotaScope{"scope-1"}
op := api.ScopeSelectorOpIn
selector := api.ScopeSelector{

This comment has been minimized.

@liggitt

liggitt Jan 8, 2019

Member

move scopes, op, and selector inside the rqWithScopeSelector and rqWithoutScopeSelector functions... the goal is for the objects those return to share no memory between invocations

This comment has been minimized.

@sbezverk

sbezverk Jan 8, 2019

Author Contributor

done

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

a couple nits, lgtm otherwise

add ResourceQuotaSelector validation and tests
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>

@sbezverk sbezverk force-pushed the sbezverk:ResourceQuotaScopeSelectors branch from 4d815c5 to d79475c Jan 8, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 8, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sbezverk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 8, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8728ecc into kubernetes:master Jan 8, 2019

19 checks passed

cla/linuxfoundation sbezverk authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 8, 2019

/test pull-kubernetes-e2e-kops-aws

@sbezverk sbezverk deleted the sbezverk:ResourceQuotaScopeSelectors branch Jan 8, 2019

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Jan 10, 2019

/cc @yliaog

@k8s-ci-robot k8s-ci-robot requested a review from yliaog Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment