Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark deprecated in related workqueue metrics #72679

Merged
merged 1 commit into from Jan 19, 2019
Merged

Mark deprecated in related workqueue metrics #72679

merged 1 commit into from Jan 19, 2019

Conversation

danielqsj
Copy link
Contributor

What type of PR is this?

/sig instrumentation

What this PR does / why we need it:

As discussed here, need to add Deprecated in the description of deprecated metrics.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 8, 2019
@danielqsj
Copy link
Contributor Author

/cc @brancz

@danielqsj danielqsj mentioned this pull request Jan 8, 2019
Closed
9 tasks
@brancz
Copy link
Member

brancz commented Jan 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@brancz
Copy link
Member

brancz commented Jan 8, 2019

/assign @smarterclayton

@smarterclayton
Copy link
Contributor

Just so I know, we are consistently using (Deprecated) for all metrics we do this to?

@brancz
Copy link
Member

brancz commented Jan 8, 2019

We are.

@danielqsj danielqsj mentioned this pull request Jan 14, 2019
Merged
logicalhan
logicalhan approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for cleaning these up!

@brancz
Copy link
Member

brancz commented Jan 16, 2019

/assign @smarterclayton

@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, danielqsj, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@danielqsj
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3ebbbda into kubernetes:master Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@brancz brancz Awaiting requested review from brancz

@brendandburns brendandburns Awaiting requested review from brendandburns

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@logicalhan logicalhan

@smarterclayton smarterclayton

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danielqsj @brancz @smarterclayton @k8s-ci-robot @logicalhan