New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving PersistentLocalVolumes feature gate check from validation #72686

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@sbezverk
Copy link
Contributor

sbezverk commented Jan 8, 2019

Signed-off-by: Serguei Bezverkhi sbezverk@cisco.com
xref: #72651

/release-note-none
/sig api-machinery
/sig storage
/kind bug

none
@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 8, 2019

/assign @liggitt

@@ -27,7 +28,7 @@ import (
"k8s.io/kubernetes/pkg/features"
)

func TestDropDisabledFields(t *testing.T) {
func TestDropDisabledFieldsCSI(t *testing.T) {

This comment has been minimized.

@liggitt

liggitt Jan 8, 2019

Member

this was also testing block mode... revert the name change?

This comment has been minimized.

@sbezverk

sbezverk Jan 8, 2019

Author Contributor

done

@@ -152,3 +153,99 @@ func TestDropDisabledFields(t *testing.T) {
})
}
}

func TestDropDisabledFieldsPersistentLocalVolume(t *testing.T) {
fsType := "ext4"

This comment has been minimized.

@liggitt

liggitt Jan 8, 2019

Member

move inside pvWithLocalVolume

This comment has been minimized.

@sbezverk

sbezverk Jan 8, 2019

Author Contributor

done

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

two nits, lgtm otherwise

PersistentLocalVolumes validation and tests
Signed-off-by: Serguei Bezverkhi <sbezverk@cisco.com>

@sbezverk sbezverk force-pushed the sbezverk:PersistentLocalVolumes branch from c3cb944 to 8915e90 Jan 8, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sbezverk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 8, 2019

/test pull-kubernetes-integration

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

/retest

@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 8, 2019

/test pull-kubernetes-integration

2 similar comments
@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 8, 2019

/test pull-kubernetes-integration

@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 8, 2019

/test pull-kubernetes-integration

@sbezverk

This comment has been minimized.

Copy link
Contributor Author

sbezverk commented Jan 8, 2019

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot merged commit 45b54f5 into kubernetes:master Jan 9, 2019

19 checks passed

cla/linuxfoundation sbezverk authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 9, 2019

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment