New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for multi-zone volume provisioning through VCP #72732

Open
wants to merge 3 commits into
base: master
from

Conversation

@sandeeppsunny
Copy link

sandeeppsunny commented Jan 9, 2019

What this PR does / why we need it:
Added e2e tests to cover multi-zone volume provisioning through vsphere cloud provider (VCP).
The tests cover the following scenarios :

  • Verify that zone labels are set correctly on a dynamically created PV with zones specified in the storage class.
  • Verify dynamic PV creation fails when zones are not specified in an environment with no shared datastores among all the nodes.
  • Verify dynamic PV creation fails when a zone specified does not have any shared datastores under it in the environment.
  • Verify dynamic PV creation with zones work in combination with other storage class parameters such as storage policy, datastore and vSAN capabilities. The tests also also brings up pods and verifies volume attachment with them.
  • Verify dynamic PV creation using availability zones fails in combination with other storage class parameters such as storage policy, datastore and vSAN capabilities specifications when any of the former mentioned parameters are incompatible with the rest.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
These tests are written to cover the changes in the following pull requests
#72687
#72731

All tests passed successfully on the above mentioned changes
Ran 19 of 2135 Specs in 1203.660 seconds SUCCESS! -- 19 Passed | 0 Failed | 0 Pending | 2120 Skipped PASS

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 9, 2019

Hi @sandeeppsunny. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 9, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sandeeppsunny

This comment has been minimized.

Copy link

sandeeppsunny commented Jan 9, 2019

@frapposelli

This comment has been minimized.

Copy link
Member

frapposelli commented Jan 9, 2019

/ok-to-test
/sig vmware

@frapposelli

This comment has been minimized.

Copy link
Member

frapposelli commented Jan 9, 2019

/cc @dougm

@k8s-ci-robot k8s-ci-robot requested a review from dougm Jan 9, 2019

@sandeeppsunny

This comment has been minimized.

Copy link

sandeeppsunny commented Jan 9, 2019

/retest

@sandeeppsunny

This comment has been minimized.

Copy link

sandeeppsunny commented Jan 11, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sandeeppsunny
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rootfs

If they are not already assigned, you can assign the PR to them by writing /assign @rootfs in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment