New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DenyEscalatingExec and DenyExecOnPrivileged admission plugins #72737

Merged
merged 1 commit into from Jan 11, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Jan 9, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Deprecates the DenyEscalatingExec and DenyExecOnPrivileged admission plugins. These do not protect creation of privileged pods, and do not allow for any differentiation between users. Use of a policy-based admission plugin (like PodSecurityPolicy or a custom admission plugin) which can be targeted at specific users or namespaces, and also protects against creation of overly privileged pods is recommended instead.

Which issue(s) this PR fixes:
Fixes #65408

Does this PR introduce a user-facing change?:

The DenyEscalatingExec and DenyExecOnPrivileged admission plugins are deprecated and will be removed in v1.18. Use of `PodSecurityPolicy` or a custom admission plugin to limit creation of pods is recommended instead.

@kubernetes/sig-auth-pr-reviews

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 9, 2019

also updated guidance in kubernetes/website#12152

@liggitt liggitt force-pushed the liggitt:deprecate-deny-exec-admission branch from edf800f to 61be368 Jan 10, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Jan 10, 2019

@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented Jan 11, 2019

/lgtm

@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented Jan 11, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 33a9c6e into kubernetes:master Jan 11, 2019

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:deprecate-deny-exec-admission branch Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment