Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl: kubectl version better error message #72740

Merged

Conversation

@prksu
Copy link
Contributor

commented Jan 9, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Better error message when cluster server in kubeconfig is running but it is doesn't seem a kubernetes cluster server which causes an error when unmarshaling response body from the server into version.Info

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#552

Special notes for your reviewer:

/cc @soltysh @sttts

This PR is a change from #71917

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Hi @prksu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prksu prksu force-pushed the prksu:kubectl-version-better-error-msg branch from e11d0f4 to 26e22a9 Jan 9, 2019

@code-sleuth

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

/ok-to-test

Show resolved Hide resolved pkg/kubectl/cmd/util/helpers.go Outdated

@prksu prksu force-pushed the prksu:kubectl-version-better-error-msg branch from 26e22a9 to 5cd6566 Jan 10, 2019

@prksu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

/retest

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

/assign @caesarxuchao

@soltysh
Copy link
Contributor

left a comment

One nit, the rest lgtm.

Show resolved Hide resolved pkg/kubectl/cmd/util/helpers.go Outdated

@prksu prksu force-pushed the prksu:kubectl-version-better-error-msg branch from 5cd6566 to da0f10c Jan 11, 2019

@prksu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

/retest

1 similar comment
@prksu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

/retest

Show resolved Hide resolved pkg/kubectl/cmd/util/helpers.go Outdated
@neolit123

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

/priority backlog

@prksu prksu force-pushed the prksu:kubectl-version-better-error-msg branch from da0f10c to 047ef3f Jan 18, 2019

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Jan 18, 2019

@prksu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 18, 2019

/retest

@sttts

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prksu, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 771baea into kubernetes:master Jan 19, 2019

18 checks passed

cla/linuxfoundation prksu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@prksu prksu deleted the prksu:kubectl-version-better-error-msg branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.