Join GitHub today
Fix the broken for loop including goroutine #72793
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
Hi @haiyanmeng. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Jan 10, 2019
This was referenced
Jan 11, 2019
The broken pull-kubernetes-node-e2e test (https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72793/pull-kubernetes-node-e2e/115981/) should be fixed after #72798 is merged.
@haiyanmeng Do we need this PR to get merged into master? Because ultimately these table based tests (all tabel tests in e2e suite) needs to be refactored into individual test in order to promote them to conformance. (#68339 (comment))
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing