Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the broken for loop including goroutine #72793

Merged

Conversation

@haiyanmeng
Copy link
Contributor

commented Jan 10, 2019

What type of PR is this?
bug

What this PR does / why we need it:
Currently, all the funcs inside the for loop is bound to the same testCase, which means only one testCase is under test, and all the other testCase are not really tested.

Which issue(s) this PR fixes:
This bug was found during debugging #70990

Does this PR introduce a user-facing change?:
No.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

@haiyanmeng: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

Hi @haiyanmeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

/area conformance
/ok-to-test

@dims

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

/release-note-none

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

The broken pull-kubernetes-node-e2e test (https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72793/pull-kubernetes-node-e2e/115981/) should be fixed after #72798 is merged.
So this PR should not be merged before #72798.

@haiyanmeng haiyanmeng force-pushed the haiyanmeng:goroutine_inside_for_loop branch from 9add78e to 79fdc09 Jan 11, 2019

@oomichi
Copy link
Member

left a comment

Thanks for the PR, just a few comments

Show resolved Hide resolved test/e2e/common/runtime.go Outdated
@oomichi

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

/assign

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

/retest

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

/test pull-kubernetes-integration

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

@oomichi, there is no more blocking PRs. PTAL. Thanks!

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 Jan 11, 2019

@oomichi

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@haiyanmeng I already put my comments on this.

Fix the broken for loop including goroutine
Currently, all the funcs in the for loop are bound to the same
testCase.

Also remove extra newline from one expected message

@haiyanmeng haiyanmeng force-pushed the haiyanmeng:goroutine_inside_for_loop branch from 79fdc09 to 408b5db Jan 11, 2019

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2019

@oomichi , I totally missed your comments. Sorry about that.
Fixed them now. PTAL. Thanks!

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

Can we do a quick review of other tests in test/* and see if this only happens here? I think I copied this from another test structure.

@spiffxp spiffxp added this to To Triage in cncf-k8s-conformance-wg Jan 11, 2019

@mgdevstack

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

@haiyanmeng Do we need this PR to get merged into master? Because ultimately these table based tests (all tabel tests in e2e suite) needs to be refactored into individual test in order to promote them to conformance. (#68339 (comment))
#70492 is in filed to achieve this which needs to be reviewed & approved.

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

We should merge this PR just in case it takes a while for #70492 to get reviews and approval.
This PR is quite easy to review since it only changes two lines.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

/lgtm

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haiyanmeng, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haiyanmeng

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Jan 15, 2019

@k8s-ci-robot k8s-ci-robot merged commit 708c1ae into kubernetes:master Jan 15, 2019

18 checks passed

cla/linuxfoundation haiyanmeng authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

cncf-k8s-conformance-wg automation moved this from To Triage to Done Jan 15, 2019

@haiyanmeng haiyanmeng deleted the haiyanmeng:goroutine_inside_for_loop branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.