Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #71681: Add e2e test for file exec #72795

Conversation

@verult
Copy link
Contributor

verult commented Jan 10, 2019

Cherry pick of #71681 on release-1.11.

#71681: Add e2e test for file exec

NONE
@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Jan 10, 2019

/kind bug
/priority important-soon
/assign @msau42
/sig storage

NFS: &v1.NFSVolumeSource{
Server: serverIP,
Path: "/",
ReadOnly: true,

This comment has been minimized.

Copy link
@msau42

msau42 Jan 10, 2019

Member

By setting readOnly, I think we won't be able to echo the script to exec

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Jan 10, 2019

This is adding a new test case for a bug found with certain kernel versions.

/assign @foxish

@verult verult force-pushed the verult:automated-cherry-pick-of-#71681-release-1.11 branch from c426a3c to 7ef69ab Jan 10, 2019

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Jan 10, 2019

Addressed comments

@foxish

This comment has been minimized.

Copy link
Member

foxish commented Jan 11, 2019

@msau42, is this good to go?

@verult verult force-pushed the verult:automated-cherry-pick-of-#71681-release-1.11 branch from 7ef69ab to e8c8bc4 Jan 11, 2019

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Jan 11, 2019

Fixed the gofmt error, but I'm not sure where the bazel build error came from. Maybe a flake?

@msau42 btw I changed the test image from Nginx to NginxSlim (since the former isn't defined in 1.11). Also simplified the test function a bit by removing the bits tailored to the new e2e testing framework

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jan 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@verult

This comment has been minimized.

Copy link
Contributor Author

verult commented Jan 16, 2019

@foxish good to go!

@foxish foxish modified the milestones: next-candidate, v1.11 Jan 17, 2019

@k8s-ci-robot k8s-ci-robot merged commit 5bf63b7 into kubernetes:release-1.11 Jan 17, 2019

18 checks passed

cla/linuxfoundation msau42 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.