New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize changes are required, reverting until those are worked through #72805

Merged
merged 1 commit into from Jan 11, 2019

Conversation

@pwittrock
Copy link
Member

pwittrock commented Jan 11, 2019

Discussion of changes to the UX integration were raised and are being talked through in kubernetes/kubectl#570. The outcome of those discussions will be folded into the KEP before reintegrating: kubernetes/enhancements#684

Additionally there were some security concerns raised that require changes, such as limiting process callouts: kubernetes-sigs/kustomize#683. The new capabilities added by kustomize will be reviewed from a security perspective prior to reintegration.

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 11, 2019

/assign @liggitt

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 11, 2019

/sig cli

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 11, 2019

/release-note-none

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 11, 2019

/kind cleanup

@pwittrock

This comment has been minimized.

Copy link
Member Author

pwittrock commented Jan 11, 2019

/priority important-soon

@pwittrock pwittrock changed the title Revert "Enable kustomize in kubectl" Kustomize changes are required, reverting until those are worked through Jan 11, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1cfdb96 into master Jan 11, 2019

18 checks passed

cla/linuxfoundation pwittrock authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment