New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit nil initialization and correct error string. #72818

Open
wants to merge 1 commit into
base: master
from

Conversation

@humblec
Copy link
Contributor

humblec commented Jan 11, 2019

Signed-off-by: hchiramm hchiramm@redhat.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Remove explicit nil initialization and correct error string.
Signed-off-by: hchiramm <hchiramm@redhat.com>

@k8s-ci-robot k8s-ci-robot added the size/S label Jan 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

@humblec: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 11, 2019

/release-note-none

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: humblec
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: thockin

If they are not already assigned, you can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 11, 2019

/kind cleanup

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 11, 2019

/assign @matchstick
/assign @lavalamp
/assign @dims

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 12, 2019

/kind cleanup

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 12, 2019

/assign @smarterclayton

@yliaog

This comment has been minimized.

Copy link
Contributor

yliaog commented Jan 14, 2019

/lgtm

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 17, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 17, 2019

@humblec: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-verify 812b7b5 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment