Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Log http request and count number of traces before logging #72820

Closed
wants to merge 1 commit into from

Conversation

@dims
Copy link
Member

dims commented Jan 11, 2019

Change-Id: I421afd7c0ef3ce7b4cd37c34b60462ce18c00fe7

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

@dims: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from enj and ncdc Jan 11, 2019

@dims dims force-pushed the dims:log-http-request-with-traces branch from ce4aea5 to 2e03fbf Jan 11, 2019

@dims dims changed the title Log http request and count number of traces before logging [WIP] Log http request and count number of traces before logging Jan 11, 2019

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 11, 2019

/test pull-kubernetes-integration

@dims dims force-pushed the dims:log-http-request-with-traces branch from 2e03fbf to c5caaab Jan 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dims
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sttts

If they are not already assigned, you can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims dims force-pushed the dims:log-http-request-with-traces branch from c5caaab to 6c49bad Jan 11, 2019

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 11, 2019

/test pull-kubernetes-integration

5 similar comments
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 11, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 11, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 11, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 11, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 11, 2019

/test pull-kubernetes-integration

Log http request and count number of traces before logging
Change-Id: I421afd7c0ef3ce7b4cd37c34b60462ce18c00fe7

@dims dims force-pushed the dims:log-http-request-with-traces branch from 6c49bad to e26e59d Jan 11, 2019

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

2 similar comments
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

5 similar comments
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

/test pull-kubernetes-integration

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 12, 2019

@dims: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration e26e59d link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 12, 2019

This PR served us well!

@dims dims closed this Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.