Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Bump Docker supported version to 18.09 #72823
For 1.14, let's support Docker 18.09 for kubeadm
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Jan 11, 2019
The code is not in yet. It's in #69366 and has been sitting in there since the beginning of October.
Does kubeadm fail with only docker 18.09 is present? (and the intention of the deployer is to use it with docker), if the answer is no, then we should just merge this PR so we can start throwing CI resources at this docker version to see what fails. Don't want to delay that process of validating newer versions to late in the cycle.
the problem is that the related PR attempts to add something that we want (eventually), yet for some reason Docker 18.09 started bundling containerd, so it will need an alternative detection method.
this decision to bundle containerd is quite odd.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here