New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find current resourceVersion for waiting for deletion/conditions #72825

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@liggitt
Copy link
Member

liggitt commented Jan 11, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Does a filtered list to get the current object and current resource version when waiting for deletion or for a condition

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubectl: fixed an issue with "too old resource version" errors continuously appearing when calling `kubectl delete`

/cc @deads2k

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 11, 2019

/kind bug
/sig cli

Show resolved Hide resolved pkg/kubectl/cmd/wait/wait.go Outdated
@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Jan 11, 2019

optional nit, lgtm otherwise

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the liggitt:wait-resource-version branch from 50952d8 to c12d8a5 Jan 11, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Jan 11, 2019

resolved nit, tagging

@liggitt liggitt added the lgtm label Jan 11, 2019

@k8s-ci-robot k8s-ci-robot merged commit 08bee2c into kubernetes:master Jan 11, 2019

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:wait-resource-version branch Jan 12, 2019

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Jan 14, 2019

/cc @jpbetz

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz Jan 14, 2019

k8s-ci-robot added a commit that referenced this pull request Jan 15, 2019

Merge pull request #72838 from liggitt/automated-cherry-pick-of-#7282…
…5-upstream-release-1.12

Automated cherry pick of #72825: Find current resourceVersion for waiting for

k8s-ci-robot added a commit that referenced this pull request Jan 15, 2019

Merge pull request #72837 from liggitt/automated-cherry-pick-of-#7282…
…5-upstream-release-1.13

Automated cherry pick of #72825: Find current resourceVersion for waiting for

k8s-ci-robot added a commit that referenced this pull request Jan 17, 2019

Merge pull request #72839 from liggitt/automated-cherry-pick-of-#7282…
…5-upstream-release-1.11

Automated cherry pick of #72825: Find current resourceVersion for waiting for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment