Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: Refactor most of `kubectl drain` as a library #72827
What type of PR is this?
What this PR does / why we need it:
Currently draining a node is only possible with
This is intended as a simple code move, there are no changes to in behaviour.
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: errordeveloper
If they are not already assigned, you can assign the PR to them by writing
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
It's going to take me a bit to work through the diff of this vs. openshift/kubernetes-drain, but just comparing the APIs, it looks like you've decided to not include (un)cordon functions? Are you expecting to do that in follow-up work? It seems like they'd be important for folks trying to use a drain library.
$ git describe --always origin/master v1.14.0-alpha.0-1656-gdc6f3d6 $ git log --oneline --decorate d43e1b3..dc6f3d6 -- pkg/kubectl/cmd/drain.go 33adf36 Move each kubectl command to a separate directory 97b2992 Update gofmt for go1.11 fecb5ed Merge pull request #66266 from wking/kubectl-drain-drop-backOff 686f29f (origin/pr/69438) Merge pull request #66301 from wking/kubectl-drain-drop-typer f008365 Merge pull request #68806 from seans3/legacy-scheme-update ab993e3 (origin/pr/66266) kubectl: Drop backOff from DrainOptions 7a2a987 Move legacyscheme (internal version) to kubectl scheme (external version) 452615c (origin/pr/68767) Fix drain for evicting terminal DS pods and pods with local storage 967280b (origin/pr/68069) Add --server-dry-run flag to `kubectl apply` 5b55e1f (origin/pr/67658) Create cli-runtime staging repository 0d81e83 (origin/pr/66301) kubectl: Drop typer from DrainOptions
4 times, most recently
Jan 12, 2019
@errordeveloper: The following tests failed, say
I am really not sure why this error appears in tests:
I assume it breaks tests as output has changed, but I worry that the above error was there before this change.