Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor most of `kubectl drain` as a library #72827
What type of PR is this?
What this PR does / why we need it:
Currently draining a node is only possible with
This is intended as a simple code move, there are no changes to in behaviour.
Does this PR introduce a user-facing change?:
referenced this pull request
Jan 11, 2019
It's going to take me a bit to work through the diff of this vs. openshift/kubernetes-drain, but just comparing the APIs, it looks like you've decided to not include (un)cordon functions? Are you expecting to do that in follow-up work? It seems like they'd be important for folks trying to use a drain library.
$ git describe --always origin/master v1.14.0-alpha.0-1656-gdc6f3d6 $ git log --oneline --decorate d43e1b3..dc6f3d6 -- pkg/kubectl/cmd/drain.go 33adf36 Move each kubectl command to a separate directory 97b2992 Update gofmt for go1.11 fecb5ed Merge pull request #66266 from wking/kubectl-drain-drop-backOff 686f29f (origin/pr/69438) Merge pull request #66301 from wking/kubectl-drain-drop-typer f008365 Merge pull request #68806 from seans3/legacy-scheme-update ab993e3 (origin/pr/66266) kubectl: Drop backOff from DrainOptions 7a2a987 Move legacyscheme (internal version) to kubectl scheme (external version) 452615c (origin/pr/68767) Fix drain for evicting terminal DS pods and pods with local storage 967280b (origin/pr/68069) Add --server-dry-run flag to `kubectl apply` 5b55e1f (origin/pr/67658) Create cli-runtime staging repository 0d81e83 (origin/pr/66301) kubectl: Drop typer from DrainOptions
4 times, most recently
Jan 12, 2019
I am really not sure why this error appears in tests:
I assume it breaks tests as output has changed, but I worry that the above error was there before this change.
As we discussed on Slack, I've moved the new package under
On Tue, 19 Feb 2019, 6:17 pm Kubernetes Prow Robot ***@***.*** wrote: @errordeveloper <https://github.com/errordeveloper>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command pull-kubernetes-e2e-kops-aws 66fdbd5 <66fdbd5> link <https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72827/pull-kubernetes-e2e-kops-aws/120254/> /test pull-kubernetes-e2e-kops-aws pull-kubernetes-e2e-gce 37abbf0 <37abbf0> link <https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72827/pull-kubernetes-e2e-gce/69228/> /test pull-kubernetes-e2e-gce pull-kubernetes-verify d7faf9d <d7faf9d> link <https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/72827/pull-kubernetes-verify/122915> /test pull-kubernetes-verify Full PR test history <https://gubernator.k8s.io/pr/72827>. Your PR dashboard <https://gubernator.k8s.io/pr/errordeveloper>. Please help us cut down on flakes by linking to <https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72827 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPWS9Lm0JPvfUdQwNBLE4l5T8dlsRn3ks5vPD_IgaJpZM4Z7wev> .
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing