Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate errors in test/e2e/network/service.go #72830

Merged
merged 1 commit into from Jan 14, 2019

Conversation

@palash25
Copy link
Contributor

commented Jan 11, 2019

Related to: #34059

Removes all occurences of the "Expect(err).NotTo(HaveOccurred())"
antipattern from the aforementioned test file.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Release Note

None

@k8s-ci-robot k8s-ci-robot added the size/L label Jan 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

@palash25: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

Hi @palash25. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from caseydavenport and MrHohn Jan 11, 2019

@k8s-ci-robot k8s-ci-robot added sig/testing and removed needs-sig labels Jan 11, 2019

@palash25 palash25 force-pushed the palash25:annotate-errs branch from 907e8f8 to 337ec97 Jan 11, 2019

@MrHohn

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

Thanks for the PR!
/ok-to-test

Show resolved Hide resolved test/e2e/network/service.go Outdated
Show resolved Hide resolved test/e2e/network/service.go Outdated
Show resolved Hide resolved test/e2e/network/service.go Outdated
Show resolved Hide resolved test/e2e/network/service.go Outdated
Show resolved Hide resolved test/e2e/network/service.go Outdated
@MrHohn

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

/sig network

@palash25 palash25 force-pushed the palash25:annotate-errs branch from 337ec97 to 84187c4 Jan 12, 2019

@palash25

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

/retest

@palash25 palash25 force-pushed the palash25:annotate-errs branch from 84187c4 to 8f89a1f Jan 12, 2019

@palash25

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

/retest

@palash25 palash25 force-pushed the palash25:annotate-errs branch from 8f89a1f to 8e3d2ae Jan 12, 2019

@palash25

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

/retest

@palash25 palash25 force-pushed the palash25:annotate-errs branch from 8e3d2ae to 8acd1fd Jan 12, 2019

@palash25

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

/retest

@palash25

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2019

@MrHohn I have made the requested changes, could you please review it again?

Thanks 😄

@palash25

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

/assign @dcbw

@MrHohn

MrHohn approved these changes Jan 14, 2019

Copy link
Member

left a comment

Thanks, LGTM with some nits

Show resolved Hide resolved test/e2e/network/service.go Outdated
Show resolved Hide resolved test/e2e/network/service.go Outdated
Show resolved Hide resolved test/e2e/network/service.go Outdated
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, palash25

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrHohn

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

@palash25 Could you also update the release note to NONE?
/kind cleanup

Annotate errors in test/e2e/network/service.go
Related to: #34059

Removes all occurences of the "Expect(err).NotTo(HaveOccurred())"
antipattern from the aforementioned test file.

@palash25 palash25 force-pushed the palash25:annotate-errs branch from 8acd1fd to 5c4b05e Jan 14, 2019

@palash25

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

@MrHohn changes made, release note section updated to none in the PR description.

@MrHohn

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

/lgtm

@MrHohn

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot merged commit 4eddb77 into kubernetes:master Jan 14, 2019

18 checks passed

cla/linuxfoundation palash25 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@palash25 palash25 deleted the palash25:annotate-errs branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.