Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an env to skip readonly-packages check #72842

Merged
merged 1 commit into from Jan 12, 2019

Conversation

@krzyzacy
Copy link
Member

commented Jan 12, 2019

In order to move CI verify job onto podutils, ref kubernetes/test-infra#10679 (comment)

/assign @ixdy @BenTheElder @cblecker

/sig testing
/kind cleanup
/release-note none
/priority critical-urgent

@krzyzacy

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2019

/release-note-none

@@ -54,6 +54,13 @@ if [[ ${EXCLUDE_GODEP:-} =~ ^[yY]$ ]]; then
)
fi

# Exclude readonly package check in certain cases, aka, in CI we don't care and a readonly package won't be touched

This comment has been minimized.

Copy link
@ixdy

ixdy Jan 12, 2019

Member

I think we intend to exclude this only in periodic jobs? might make sense to say that explicitly.

This comment has been minimized.

Copy link
@krzyzacy

krzyzacy Jan 12, 2019

Author Member

done

@ixdy

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

/cc @sttts

@k8s-ci-robot k8s-ci-robot requested a review from sttts Jan 12, 2019

@krzyzacy krzyzacy force-pushed the krzyzacy:force-check branch from b3a4cec to 7e76524 Jan 12, 2019

@krzyzacy

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2019

/retest

@ixdy

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

/lgtm
/approve
/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 42db4c1 into kubernetes:master Jan 12, 2019

18 checks passed

cla/linuxfoundation krzyzacy authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.