Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed call area of 71875 cleanup #72843

Open
wants to merge 2 commits into
base: master
from

Conversation

@wgliang
Copy link
Member

wgliang commented Jan 12, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #71859

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot requested review from bsalamat and cblecker Jan 12, 2019

@wgliang wgliang force-pushed the wgliang:cleanup/missed-call-area-of-cleanup-71875 branch from a4d8837 to af302c7 Jan 12, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XS labels Jan 12, 2019

@wgliang wgliang force-pushed the wgliang:cleanup/missed-call-area-of-cleanup-71875 branch 5 times, most recently from a0471d1 to b131219 Jan 12, 2019

@wgliang wgliang changed the title Fix missed call area of 71875 cleanup [WIP]Fix missed call area of 71875 cleanup Jan 12, 2019

@neolit123
Copy link
Member

neolit123 left a comment

/area test
/kind cleanup
/priority backlog

@wgliang wgliang force-pushed the wgliang:cleanup/missed-call-area-of-cleanup-71875 branch from b131219 to ea62c94 Jan 19, 2019

@@ -81,32 +104,5 @@ func StartScheduler(clientSet clientset.Interface) (factory.Configurator, Shutdo
close(stopCh)
klog.Infof("destroyed scheduler")
}
return schedulerConfigurator, shutdownFunc

This comment has been minimized.

Copy link
@wgliang

wgliang Jan 19, 2019

Author Member

@misterikkit How can I return schedulerConfigurator? Need to get the schedulerConfigurator here, otherwise we need to delete a lot of code related to it.

@wgliang wgliang force-pushed the wgliang:cleanup/missed-call-area-of-cleanup-71875 branch from ea62c94 to 5953378 Jan 21, 2019

@wgliang wgliang changed the title [WIP]Fix missed call area of 71875 cleanup Fix missed call area of 71875 cleanup Jan 21, 2019

context.scheduler, err = scheduler.New(
context.clientSet,
context.informerFactory.Core().V1().Nodes(),
context.informerFactory.Core().V1().Pods(),

This comment has been minimized.

Copy link
@misterikkit

misterikkit Jan 24, 2019

Contributor

I think you should be using the local podInformer variable here.

@misterikkit

This comment has been minimized.

Copy link
Contributor

misterikkit commented Jan 25, 2019

So this change is leaving the "configFactory" field in the "test context" but it is nil, causing a panic during integration test. For this PR, I think we need to fully remove Configurator/configFactory references from the test/integration/... tree.

panic seems to be in initTestSchedulerWithOptions() of test/integration/scheduler/util.go

@cblecker cblecker removed their request for review Jan 27, 2019

@wgliang wgliang force-pushed the wgliang:cleanup/missed-call-area-of-cleanup-71875 branch from 5953378 to 7b5ec0f Jan 28, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 28, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgliang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: timothysc

If they are not already assigned, you can assign the PR to them by writing /assign @timothysc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wgliang added some commits Jan 12, 2019

@wgliang wgliang force-pushed the wgliang:cleanup/missed-call-area-of-cleanup-71875 branch from 07adfe2 to ffa4273 Jan 28, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 28, 2019

@wgliang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-typecheck ffa4273 link /test pull-kubernetes-typecheck
pull-kubernetes-node-e2e ffa4273 link /test pull-kubernetes-node-e2e
pull-kubernetes-integration ffa4273 link /test pull-kubernetes-integration
pull-kubernetes-e2e-kops-aws ffa4273 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-verify ffa4273 link /test pull-kubernetes-verify
pull-kubernetes-e2e-gce ffa4273 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 2, 2019

@wgliang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.